[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: compat code lacks support for __attribute__


  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 14 Jun 2023 12:26:31 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bvunzSABM5VefzDQnaIUOO5ataf1NXi6TrR0B3u7FPM=; b=Y4EeubsMsYyvN2R9phD3SulvTzHvJr6Bb/pD+yzk4w1KUsF1oZlZaGHwGhkFlzsv5MrmVx/QdyKEWK3vFXpPqNUY6FAMY5tbSY5U1x1cS3eNIkx+styWX+1KE7Jj87ewk6vYdnut28/jDwgRLzWCQm62jHLWwDP+72Nlj5lDceZfeWcc1q9HSPvfExpUfa7isKi6cUncWxMuxIVDlYuzSOEDpHip3FbffE45QlJsYxoZPVVL/XtpO9rccRK5z2VWDGAbChjqFWhovRse+HY4hu7Em8zR5FfakMCjEL8huc0zy42JjeMsb151+te7gxHuah8GMUHKK/x2dPEQmCHPZA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XFfTvVnJHh6xxX5uzq9RN/yv1/K0UUjgO5J873BqmdTy0JGccxyGMzl8Y0jMeBHC2BEjKXoHhK97Otcf77w4MeghgsLVabzpt5OPHJbHSKzPJjaVuzbV9egaeMaMY/LYd2lHQRcDxE/orhXNCIGVeNMyvx1EYjD2GvpHxU0Ui0jIQ3P2AoApszMblVIVIM74pdPz2KH9ayaOxrr2XcAvTdv+WE79yT2+gDYroy7DEUZmR3wZwS9yGpR2mtm45iCu5dYONbqsfgnMjVLE1N89q23Gtobni8DgeXIdNv4hSJfhEsZm2pvIWjRWkjRDuBMbjTSbYjkwbGyvehTSVAxlsQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 14 Jun 2023 10:26:52 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.06.2023 12:08, Olaf Hering wrote:
> Wed, 14 Jun 2023 11:49:35 +0200 Jan Beulich <jbeulich@xxxxxxxx>:
> 
>> So perhaps we could arrange for your additions to be excluded
>> from the compat translation machinery?
> 
> Is there maybe a place for headers which are not public,
> but which are visible for tools/ and xen/? I think the trace
> functionality would be a candidate for such local shared headers.

I'm not sure I understand what you're after. The "public" here means
the externally visible interface of the hypervisor. Aiui the header
your thinking of still falls in this category. In how far checking
and translation need to be done for any particular header under
public/ is controlled by xen/include/Makefile. So if you were to
introduce a new header for your specific purpose, all would depend
on what, if anything, you add to that makefile. I don't think we
currently have any header which is entirely unmentioned there, but
with the right justification I don't see why this couldn't change
(or perhaps such a header might simply be added to headers-n, so
it's clear that it wasn't just an oversight that it's not listed
anywhere [else]).

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.