Re: [PATCH v4 33/34] um: Convert {pmd, pte}_free_tlb() to use ptdescs

[Mike Rapoport <rppt@xxxxxxxxxx>]

On Mon, Jun 12, 2023 at 02:04:22PM -0700, Vishal Moola (Oracle) wrote:
> Part of the conversions to replace pgtable constructor/destructors with
> ptdesc equivalents. Also cleans up some spacing issues.
> 
> Signed-off-by: Vishal Moola (Oracle) <vishal.moola@xxxxxxxxx>

Acked-by: Mike Rapoport (IBM) <rppt@xxxxxxxxxx>

> ---
>  arch/um/include/asm/pgalloc.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h
> index 8ec7cd46dd96..de5e31c64793 100644
> --- a/arch/um/include/asm/pgalloc.h
> +++ b/arch/um/include/asm/pgalloc.h
> @@ -25,19 +25,19 @@
>   */
>  extern pgd_t *pgd_alloc(struct mm_struct *);
>  
> -#define __pte_free_tlb(tlb,pte, address)             \
> -do {                                                 \
> -     pgtable_pte_page_dtor(pte);                     \
> -     tlb_remove_page((tlb),(pte));                   \
> +#define __pte_free_tlb(tlb, pte, address)                    \
> +do {                                                         \
> +     pagetable_pte_dtor(page_ptdesc(pte));                   \
> +     tlb_remove_page_ptdesc((tlb), (page_ptdesc(pte)));      \
>  } while (0)
>  
>  #ifdef CONFIG_3_LEVEL_PGTABLES
>  
> -#define __pmd_free_tlb(tlb, pmd, address)            \
> -do {                                                 \
> -     pgtable_pmd_page_dtor(virt_to_page(pmd));       \
> -     tlb_remove_page((tlb),virt_to_page(pmd));       \
> -} while (0)                                          \
> +#define __pmd_free_tlb(tlb, pmd, address)                    \
> +do {                                                         \
> +     pagetable_pmd_dtor(virt_to_ptdesc(pmd));                        \
> +     tlb_remove_page_ptdesc((tlb), virt_to_ptdesc(pmd));     \
> +} while (0)
>  
>  #endif
>  
> -- 
> 2.40.1
> 
> 

-- 
Sincerely yours,
Mike.