[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] Arm: drop bogus ALIGN() from linker script
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 14 Jun 2023 18:07:07 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fdLN1IgKFlYB0/23G0Y7VBn558guk0oug7RQ6CXwIjY=; b=nn6YPNA1d6wRMtsvvLEWjL4TdUhDzfq+3Un98cp3NpqMX8HOtsH3GT7KczQwO6WqEi806INmflPZS3kwJKZxuiKPkXj6+nsqtYLOKOV3Cxz5zvKf/lzwb+j+lffzUWh7fceGu2woUUfgXGUqVRZ5iM8IJXLR9NnNwBOFboRoBGpoCg1fp6pIUSIX7so4CRQ2p+My88N7MzkO+lVFamN4d9PkxoLSCapneP15oTWYdMh1qgnxoNdRlHwYypzsxh6k8mHTCCnF1ra5hmLn2K0Hcs90BaYASbkFnHkS3unebgH76g2uc2RUrZVUHSLvu4WCPE88NSR8arMPlLTrXrUlMQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WTWsfBpLpasMfkThWChAB8V0+DXx1CEP8PmJ773huzZuSabhu4Jr+a2dZq+dukmV8dm7F36Opdrgajqhn42uq8ITVy/TsljQNcm62kmYmESXR6exrMwhdnqcFb5K5x6R3XGztRySBlWu6QuLmDlk1x7fe8Lo0JDkkqTPWa9peBPEXwyda/6Nsg3QpCiy6HPnj4vSf7zmJSZqg1ufV4I2R/Rf7uAbFVnQF0voSCKWYbvnA/SF5AoVzscFSYRao6I6BNYEhgsTBqAl9ati92a76o8InQoQuHsmE6A5cKJIQwwJPECi40l5z8QuyhabGv4/aAI5FmNxKH8am8YH5UJo1Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <volodymyr_babchuk@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>
- Delivery-date: Wed, 14 Jun 2023 16:07:20 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Having ALIGN() inside a section definition usually makes sense only with
a label definition following (an exception case is a few lines out of
context, where cache line sharing is intended to be avoided).
Constituents of .bss.page_aligned need to specify their own alignment
correctly anyway, or else they're susceptible to link order changing.
This requirement is already met: Arm-specific code has no such object,
while common (EFI) code has another one. That one has suitable alignment
specified.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
---
Note how RISC-V had this dropped pretty recently.
--- a/xen/arch/arm/xen.lds.S
+++ b/xen/arch/arm/xen.lds.S
@@ -199,7 +199,6 @@ SECTIONS
.bss : { /* BSS */
__bss_start = .;
*(.bss.stack_aligned)
- . = ALIGN(PAGE_SIZE);
*(.bss.page_aligned)
. = ALIGN(PAGE_SIZE);
__per_cpu_start = .;
|
