[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/4] xen: Add files needed for minimal ppc64le build
- To: Shawn Anastasio <shawn@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 15 Jun 2023 08:47:16 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/G/gnCkroko4U8ZZM2HLq4J4bcmK8s6b1bZVZGd3O1o=; b=fzBMLhvM3WJ7yVYYUtu4iXE0YMQS3xviaDOktBIZOsXgjqLNshlWmbvNatMUIn9h9Q1+pwISp51BQrVcyl0i55Dy4Rk0nwUyWZuqdGV4y493IKwbzY0OaIk1mvfYyBe7xuODRc6DfQ/l3dl8Se4vjGKqlIRasAeggpCPiFj+hzqNBD1ENM9WVM3YxCaNMJC2jg+381RWRWJSDJcn9LvRrYaUQ/CwnB8/d+oAL80N8Bz1XpMwsqMzkPxPf3FLUxuqE9uJ+Owy+Pi9IH+6SnCUVlTB4TEspusDh/a0UNMqzY8fwoa2sjSnANA9auxlnZWj2Su6fSxQm9MnA/qiVrKfWg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZMeORvvDrMuJB8+z92Bi5m0NyRkVJT+vJrpIkh3KHQ/F8hV+V3yZrbMIVirdNXpnCkicQvpXAT/jx0ERlxZBmEdg2acjMvyIJRGZVbW28DToClsFTXSPx6CfcVl5aiUKLycmSE9IWilPl2dvh6vCMJ8eNz0ymP/KTa36aFsh66rvK7xD2arprnTu2jxRUt9RREEZDKa2sNZxabbzQ2mHvoD3w9kwzOrz5h6Xhvr3j70vbYZne3VE5nQ1VuRL0Ej4GEm5CDPNbYGfOLppQ0dIKFN3og/aGlOGDlhD0aNzK83O4cqaZBQWgPrwf4vbI9ZDoBTSM2NVewziKYoz7Axw9A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: tpearson@xxxxxxxxxxxxxxxxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 15 Jun 2023 06:47:31 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 14.06.2023 18:36, Shawn Anastasio wrote:
> On Wed Jun 14, 2023 at 10:51 AM CDT, Jan Beulich wrote:
>> On 13.06.2023 16:50, Shawn Anastasio wrote:
>>> + DECL_SECTION(.bss) { /* BSS */
>>> + __bss_start = .;
>>> + *(.bss.stack_aligned)
>>> + . = ALIGN(PAGE_SIZE);
>>> + *(.bss.page_aligned)
>>
>> ... the one between the two .bss parts looks unmotivated. Within
>> a section definition ALIGN() typically only makes sense when followed
>> by a label definition, like ...
>
> Correct me if I'm wrong, but wouldn't the ALIGN here serve to ensure
> that the subsequent '.bss.page_aligned' section has the correct alignment
> that its name implies?
Yes and no. Thing is that every contribution to .bss.page_aligned already
needs to specify page alignment itself, or else it may break if any earlier
contribution was page-aligned, but not a full page in size (which I think
the compiler wouldn't allow to happen, but assembly code can result in
such). Note how this very ALIGN() was recently dropped from RISC-V code,
and my respective Arm side patch is also about to go in.
Jan
|
