[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/misra: add rules 1.4 and 2.1


  • To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 15 Jun 2023 10:43:16 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TV5g7q92JENy3mRZHUo46btEJi5t856kzCuyg6iwtzM=; b=L8kDprOzSEl9nw5bo3Y5Wa0af4oI1FrWTEVI4l78oxvPIfYtFZfX8zp/l+mxYrcjkTWgvS/iOP2pQwfp5CU0i3fmsygMmx060sqPPniMvQ4fEJxwpufQ2JhfShhTSI06atp8W24Rj1Hobe/x/GS4BzSDQnt5zyd5+f7aLbjimRO9puEOnM8Us3dXnuoHcufyHjLbbT4XhPDgUGTcrvoAQ5NNQnkAanWWSy0gpg0YD70WmF/TPCCrrnfNJkHnDt+YqFOr5Jh2VbKZ9EILk6dvICHC0ZuqbdK3lk5yHeIhBSFZZi8M+lS8REh5sPBuyA4I8exKur8j10hvThiM3+zRQg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fee6CxXuG0ACh00oaSdFDOf46VCeI68POyvB1Pl9+6Ff4ACIZdfjCtsHHOIyF+8PIG6ZoB+aTRKh6sHOgMsGHeMkHQuTSbQ5a26oewB/6N7uxyjmJmIc0O03HThcdHusz9ASBnF6O65eemBZ07KNbkauWujkznrIuAYvj21W+9J05+hxG3etz8LkkfnTtJJ0yZfTjh1xLFUi7qHqXM0ndmmBlWQnY4sZ4fc0GlpxPNN2oElov/qtRbyb/TluDxvrf1MNs15Ko8px8kwQ5l4m4n7kKgJo0dVEGbOi74ZU+ta984bsRqlX9lkapwmMIsPXioUr/Uvd1lelK230tn1NfQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: julien@xxxxxxx, andrew.cooper3@xxxxxxxxxx, roger.pau@xxxxxxxxxx, bertrand.marquis@xxxxxxx, roberto.bagnara@xxxxxxxxxxx, Stefano Stabellini <stefano.stabellini@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 15 Jun 2023 08:43:33 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15.06.2023 01:03, Stefano Stabellini wrote:
> --- a/docs/misra/rules.rst
> +++ b/docs/misra/rules.rst
> @@ -90,6 +90,17 @@ existing codebase are work-in-progress.
>         behaviour
>       -
>  
> +   * - Rule 1.4
> +     - Required
> +     - Emergent language features shall not be used
> +     - Emergent language features, such as C11 features, should not be
> +       confused with similar compiler extensions, which we use.

The plans to possibly use _Generic, as mentioned during the discussion,
are (I think) making this the first case where we accept a rule with
the expectation to later break (deviate) it. I don't think I'm aware of
provisions in this regard, so by accepting the rule in the form you
suggest may well lead to people later pointing here and say "no" to any
attempt to use _Generic. IOW I think it wants clarifying in the text at
the top of the file that there is flexibility to change in how far we
mean to comply to already accepted rules.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.