[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] xen/misra: add rules 1.4 and 2.1
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 16 Jun 2023 06:57:19 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WyoZ1JjqFNvCAly0Fcxmqd0FMh+/TPd9uuitzR22yKE=; b=Tku1FKFu6KbNeqS1qTazLMLRzc3b3D/E5uW8IBMUJNaJ6pWQAZJ7WTPZzzP5E2xhs2oPkuIoXnXBIDwZnp3fqbCQLDKCRMGV0PJ82ixbv164ChUuAKMCxrpwY/mtzp3ZyNZPT6DaYW0PM542RoM2htUrnjsNAMe+23jl32LpgkhnUVL+Ajnmb3X7P365HZ1oDjKDJAOT+S72ZO+UFAZKaSoeOm5ebG88b+fKlmOUGxmMFTDEWJDNLeqcyNAaSi5osc4brmtq5LOPTzKTu/U2dzHpswajNd67nOcmAlUzT+LN1TkoF5Fa2wdwcMaEcB4fspff+tT/xWlLA0nfqxYNIQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZGKDAsxtm8Tpcp1W65wCiG/F6OxlRrCYc3XJEMiETAXvvmruZ91KEAhtyupk6AasBhSvLZk4gNPhgrYG08zCkfXmKx5i1jd2whMaEmMg+Iq09BL6Knf7PiTZGJrHAdpGKD7LgREYiiW6sU2v2/vHPoO/AbmI+xS/wEQEOwDbcpaW0ryEuGwrVW4q/zFIdKDZvSPO2s/1WciSEI1madg+MI5gXt3lpbd3d0anajq81woLP2O5RPpzF4bdHynBHcF2InJQXFFWnEQxlStwYSqRA/0TQPLNPyG/v5uZGK7ebTgoboA/k5TojzWMyK+4eKGQfirKlUsnfAB1TSXQppiamw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "roberto.bagnara@xxxxxxxxxxx" <roberto.bagnara@xxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>
- Delivery-date: Fri, 16 Jun 2023 06:57:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZn9A1cetUSIw+5k+zCggrDNtc/q+M/+mA
- Thread-topic: [PATCH v2] xen/misra: add rules 1.4 and 2.1
Hi Stefano,
> On 15 Jun 2023, at 23:27, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> From: Stefano Stabellini <stefano.stabellini@xxxxxxx>
>
> Also add a comment at the top of the file to say rules.rst could be
> changed.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
>
> ---
> Changes in v2:
> - add link for 1.4
> - expand 1.4 comment to say it could be revisited
> - add comment at the top
> ---
> docs/misra/rules.rst | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/docs/misra/rules.rst b/docs/misra/rules.rst
> index a88c284e7d..11b9c42b70 100644
> --- a/docs/misra/rules.rst
> +++ b/docs/misra/rules.rst
> @@ -32,6 +32,9 @@ violations are meant to be documented as deviations, while
> some others
> should be fixed. Both compliance and documenting deviations on the
> existing codebase are work-in-progress.
>
> +The list below might need to be updated over time. Reach out to THE REST
> +maintainers if you want to suggest a change.
> +
> .. list-table::
> :header-rows: 1
>
> @@ -90,6 +93,18 @@ existing codebase are work-in-progress.
> behaviour
> -
>
> + * - `Rule 1.4
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/>`_
> + - Required
> + - Emergent language features shall not be used
> + - Emergent language features, such as C11 features, should not be
> + confused with similar compiler extensions, which we use. When the
> + time comes to adopt C11, this rule will be revisited.
> +
> + * - `Rule 2.1
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_02_01_1.c>`_
> + - Required
> + - A project shall not contain unreachable code
> + -
> +
> * - `Rule 2.6
> <https://gitlab.com/MISRA/MISRA-C/MISRA-C-2012/Example-Suite/-/blob/master/R_02_06.c>`_
> - Advisory
> - A function should not contain unused label declarations
> --
> 2.25.1
>
|
