[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: xentrace buffer size, maxcpus and online cpus
- To: Jan Beulich <jbeulich@xxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- From: Olaf Hering <olaf@xxxxxxxxx>
- Date: Fri, 16 Jun 2023 13:47:08 +0200
- Arc-authentication-results: i=1; strato.com; arc=none; dkim=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; t=1686916035; s=strato-dkim-0002; d=strato.com; h=References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Cc:Date: From:Subject:Sender; bh=+JAwBarfPfVRONQKvkhvJMNBYqOxNfnw0XkD4Q9Kc8E=; b=EXXhg35WtDESm0ZG+YayhD1rPVxNCqmu3YbQ3Bl9YS8iIJ5yEINNQ5JNHPVMQoC8IP 54wURqwNTtt3He9fLSyAOhMFIFO9XjEjHcUP7jQRoZPFVjkX2KCR87taK/d3Cjm+xnRA GefoNMWccjL/JHDwL//JIxzjM/QXp34T9SiIQnoK4/WUJZxSMAE1emCnwgw+w5TzT4OL WxGv98c5toVtVOdwiFkVZ9FHCkxuS/sV8xwnvTXUtXf6ADN11K+0RmTptS4kWlwJtgJN fkcMlqyc4qJqAk3KV2BXSdC/ed5xsQGUXwK6ZB/QivHupcX0fikxKQcLacbwDcxEIXlI EJfQ==
- Arc-seal: i=1; a=rsa-sha256; t=1686916035; cv=none; d=strato.com; s=strato-dkim-0002; b=PZ2xoQ75y+NvZPgMj1QKuR01CKimrB6vhbJBOxf2Igs4jMqkhL+EDo7oOPYg56wofC RomLuyQ/KYlTH6QTKQPBdc1Tj8lYfxGINd3qzQas6SDqHqCbJ8B4929T11hfK5kkLidF QzclO+D/hRRya7h8JZJl8P8SwEySKnorDR1Z6adYixaCLtlISaEQCG5d/dob7TutOTGn xzxbI9aHywWvcmVFsqfwbS0DNFTTR6kTeE7a8GDGkCz1hQYXE6jwDGrhYun0ysstxhgI dbeFRVuz1B0MXeBABFTa7n7Mm/aZ9OXsefU5/phUeDeWlRAimQzJmGZPtEN2GdZccFJV /e/Q==
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 16 Jun 2023 11:47:32 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Wed, 31 May 2023 11:05:52 +0200 Jan Beulich <jbeulich@xxxxxxxx>:
> As said before, num_online_cpus() will under-report for the purpose
> here, as CPUs may have been brought offline, and may be brought online
> again later (independent of the use of "maxcpus=").
It turned out, commit 74584a367051bc0d6f4b96fd360fa7bc6538fc39 broke
the expected behavior. But to me it is unclear what bug was fixed by
this commit.
If I read alloc_trace_bufs correctly, it already operates on online
cpus. And __trace_var will do nothing if called on a cpu which was
not online, t_bufs will likely be NULL.
To me it looks like commit 74584a367051bc0d6f4b96fd360fa7bc6538fc39
could be reverted.
Olaf
Attachment:
pgpPJ0ZRd_tz0.pgp
Description: Digitale Signatur von OpenPGP
|
