[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] xen/trace: remove trace_will_trace_event
- To: Olaf Hering <olaf@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Mon, 19 Jun 2023 14:03:31 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d8BPQxGBWr0IctFJzC/8mc1E/TFhGV3kEYrVVCZ2bVY=; b=TgnDLMa7SbI4cE186RaZkTJSNi22tqNIeNt/vj0NPpCR+xyRyxkc+G+WTRatthOb37nzdXpXiY7ch+sywMaYxKfNveJmM6svBg0l6f5sEPmGdBFjhObeUun94Bl86vbBI6jP1bcruQHScXV8simR+vUivwO1/DOxlkLtCIUKWZ4gAoGEmb3nN3g+of/dUrFeCOGJHavOnL1obdls6H3p5Ip9QkTGa+uAx3mFgW2BiAeKQBVFotsuZ7Xw2mgHIDgOY7S7h3W5kC/sNUxrk4njTmAiIMa+Gs8wPg+SR8p1zwz5oBvbrYp4EWyWrpEdkYdMMZCJUczIteMm/kjbPAw9fQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Khp2ZgQoPkwTwp4oiXj1UkQqtxI0ThF5imKyjk+bgXWgVOyaRGghvRjYTih89eMWv8JQPp5u/8/VrFjVPa+ylBtoohk3qvAeo9IZUxfNa0ArXPq6YpuW+z47eOUPr2CzsFGfLKXpbaDlKIvHJWXGPkm6l+940S58xdQcuLNJuBGt8qGwXNYJwPs9sgW/wxB4JRXYBg84wHNTWqQOPRsikm/pCMlyWUHgGwVEyKpVugfZaJRBM2GBJheV1u2Ln3JHlY1Gi8X8bP3hU9DQnOjTbnIVWANPrLB18wKV4ceF4x+ocMq1yrORsXmkwV5L2jiV6U22cRnVTQ1egzOPr+or6w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
- Delivery-date: Mon, 19 Jun 2023 13:04:00 +0000
- Ironport-data: A9a23:Z/twh60zQ5cwlNY7DfbD5TNwkn2cJEfYwER7XKvMYLTBsI5bpzVUn zFKXmDTM66MNjHyLot0a4XgoEsGu5fQyoAyGVY/pC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefTAOK6ULWeUsxIbVcMYD87jh5+kPIOjIdtgNyoayuAo tq3qMDEULOf82cc3lk8teTb8HuDgNyo4GlD5gJnNKgS1LPjvyJ94Kw3dPnZw0TQGuG4LsbiL 87fwbew+H/u/htFIrtJRZ6iLyXm6paLVeS/oiI+t5qK23CulQRrukoPD9IOaF8/ttm8t4sZJ OOhF3CHYVxB0qXkwIzxWvTDes10FfUuFLTveRBTvSEPpqFvnrSFL/hGVSkL0YMkFulfE25I1 tMzNDY3YT+7p8jvnb/ka6ozv5F2RCXrFNt3VnBI6xj8VKxjZK+ZBqLA6JlfwSs6gd1IEbDGf c0FZDFzbRPGJRpSJlMQD5F4l+Ct7pX9W2QA9BTJ+uxpvS6PnGSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHqhAN1KS+fjnhJsqF2B72oTJSYUbGKmnMaGulC9APxPE nVBr0LCqoB3riRHVOLVWBmxrlaNswYSX9cWH+BSwBGAzO/Y7hiUAkAATyVdc5o2uckuXzso2 1SV2dTzClRHsreYVHac/be8ti6pNG4eKmpqTTAAZRsI5Z/kuo5bphDSSJBlGa28jNzwEBnxx SyHqG41gLB7pc0GyaS9u0zGijSEp57VQwpz7QLSNl9J9St8bY+hIom3s17S6K8aKJ7DFgXR+ n8Zh8KZ8eYCS4mXkzCAS/kMG7fv4OuZNDrbghhkGJxJGymRxkNPtLt4uFlWTHqF+O5dEdM1S Cc/YT9s2aI=
- Ironport-hdrordr: A9a23:EKMftqy9coYBIti2Dyj0KrPwAL1zdoMgy1knxilNoEpuA6ulfq eV8MjztCWatN91YhodcL+7VpVoLUm8yXcW2/hzAV7SZmnbUQKTRekJgLcKpQeQfhEWndQtt5 uIHZIOcOEYJGIK6frS0U2VFMsh3cnC0I3Av5ak8561d3ANV0i31XYBNjqm
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19/06/2023 1:18 pm, Olaf Hering wrote:
> There are just two callers of this function. It is identical to the
> checks done in __trace_var.
> The commit message of 9a86ac1aa3d2ebe1be05dc7fe78dd6759aa3241d
> ("xentrace 5/7: Additional tracing for the shadow code.") gives no
> indication what the benefit of this function is.
>
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
This looks like it is meant to avoid double-tracing the #PF if
TRC_SHADOW is active.
~Andrew
|
