[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/4] xen: Add files needed for minimal ppc64le build
- To: Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 20 Jun 2023 08:43:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T8+qmwKYLtv0OXg8IZ6efMfNz6pbzqUUf6Ey7Im5JAY=; b=BKzFEQjtUHwiuqnpiXsbOtroPdGJMLYzgioSusrXNAZhcD8LA3fV0c2gMbK2KZGLzvC61GxVszGECXW9tsBu9xLyUuQkwCvcr5qda5H7J4BbykcSFiP/KvM/H3TSDuxY78JEPqXaHOrJGptwK5AgG2jk+v+WdJbVqgZjeJ898oKQLIAir2dMqEnWvqakUfE1T4bWt6Uojv/eQirbKxWeh1E1lvwxh0u7OXw2SQ5XIfZdxW1u1WBpya3l3fFbPo3sNGPW1gnvMDUh0LThKHb05PnyqDuEQHtmz5exYdBhSrwCgWt71vo2aWkFdgYeOaiPtux3ofJGtZTu8KyDNM2Plw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nvd6RArq3Jlzi5Rw1dU4epvYKtSl+ewETtqjMvfIkFY0ZgQRP3yQstsHYGrUoKXgGC0O+WsdFSPuqd6CvHPL9TfA1aUksB5mQZGRo6fAy3bWRs0YdeWk1K4pqGW/qVS9k/irn53kXzvyf/IzkV/jEp2qH4B/b4q1kG15kglWdCX5k9ihDOXawYKIv5sif03+tN+woQdZfUPAl43heUCFN+jwL74OMv1r7dQiS749eXzH9YrbbyfM29YHIO8bATPOOt4uV6v8tOQyH7LRt4gikIeXpViH6DprsicAIdmb9SaqHk8DnMVXQFFiVdK2ylBWWgLxUe1bRJCG/a/0d7PYdg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: tpearson@xxxxxxxxxxxxxxxxxxxxx, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 20 Jun 2023 06:44:16 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.06.2023 18:29, Shawn Anastasio wrote:
> On 6/19/23 11:07 AM, Jan Beulich wrote:
>>> Good point. Following the example in the Power ELFv2 ABI
>>> specification [1] for function type annotation, I'll place
>>>
>>> .type start, @function
>>>
>>> in the ENTRY macro. It's not clear what the difference between %function
>>> and @function are in this context (my toolchain seems to accept both and
>>> produce the same ELF metadata), but the latter is more idiomatic in
>>> Power assembly. The same goes for its placement before the entrypoint
>>> vs. after the last instruction.
>>
>> % and @ are entirely the same here, except for targets like arm-*,
>> where @ starts a comment.
>
> Okay, thanks for the confirmation. Is there a preference for which one
> is used? I'd lean towards @ just for the sake of remaining idiomatic,
> but since they're equivalent it doesn't really matter from my
> perspective.
In arch specific code your fine to use what you think is a better fit.
There's a proposal though to make these ELF annotations arch-independent,
and if we went that route, we'd have to use % (or allow arch overrides)
to fit all architectures.
Jan
|
