|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [XEN PATCH 11/13] xen/vpci: fixed violations of MISRA C:2012 Rule 7.2
From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline
states:
"A "u" or "U" suffix shall be applied to all integer constants that are
represented in an unsigned type".
I propose to use "U" as a suffix to explicitly state when an integer constant
is represented in an unsigned type.
Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
---
xen/drivers/vpci/msi.c | 2 +-
xen/drivers/vpci/msix.c | 2 +-
xen/drivers/vpci/vpci.c | 6 +++---
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/xen/drivers/vpci/msi.c b/xen/drivers/vpci/msi.c
index 8f2b59e61a..7908a5dac6 100644
--- a/xen/drivers/vpci/msi.c
+++ b/xen/drivers/vpci/msi.c
@@ -124,7 +124,7 @@ static void cf_check address_hi_write(
struct vpci_msi *msi = data;
/* Clear and update high part. */
- msi->address &= 0xffffffff;
+ msi->address &= 0xffffffffU;
msi->address |= (uint64_t)val << 32;
update_msi(pdev, msi);
diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c
index 25bde77586..d440ffcd81 100644
--- a/xen/drivers/vpci/msix.c
+++ b/xen/drivers/vpci/msix.c
@@ -531,7 +531,7 @@ static int cf_check msix_write(
case PCI_MSIX_ENTRY_UPPER_ADDR_OFFSET:
entry->updated = true;
- entry->addr &= 0xffffffff;
+ entry->addr &= 0xffffffffU;
entry->addr |= (uint64_t)data << 32;
break;
diff --git a/xen/drivers/vpci/vpci.c b/xen/drivers/vpci/vpci.c
index d73fa76302..3bec9a4153 100644
--- a/xen/drivers/vpci/vpci.c
+++ b/xen/drivers/vpci/vpci.c
@@ -319,7 +319,7 @@ static void vpci_write_hw(pci_sbdf_t sbdf, unsigned int
reg, unsigned int size,
static uint32_t merge_result(uint32_t data, uint32_t new, unsigned int size,
unsigned int offset)
{
- uint32_t mask = 0xffffffff >> (32 - 8 * size);
+ uint32_t mask = 0xffffffffU >> (32 - 8 * size);
return (data & ~(mask << (offset * 8))) | ((new & mask) << (offset * 8));
}
@@ -402,7 +402,7 @@ uint32_t vpci_read(pci_sbdf_t sbdf, unsigned int reg,
unsigned int size)
data = merge_result(data, tmp_data, size - data_offset, data_offset);
}
- return data & (0xffffffff >> (32 - 8 * size));
+ return data & (0xffffffffU >> (32 - 8 * size));
}
/*
@@ -427,7 +427,7 @@ static void vpci_write_helper(const struct pci_dev *pdev,
data = merge_result(val, data, size, offset);
}
- r->write(pdev, r->offset, data & (0xffffffff >> (32 - 8 * r->size)),
+ r->write(pdev, r->offset, data & (0xffffffffU >> (32 - 8 * r->size)),
r->private);
}
--
2.41.0
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |