[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/13] libs/guest: simplify xc_cpuid_apply_policy()
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 20 Jun 2023 12:40:29 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O0AYFJHfbsWuBl8JGJk71EVGbbM5rg9eQnbUWVghgUk=; b=guoPV0C4hKQkA6krMNM3/jq3pB8SuyFBKaaOZQ7ZbWyj5faBOPBdebr5J/CEXg/oWHzUab5Q2BzRNaQd+9YRBE38i0rFp+CMZMJ+JMoFRQ33LtOH/cUT/JCtVqCfoh3Ly6Xn/RCdGAYmDFR0jiFQ60BWD09nxExhKiFW1+dqJYL93jusyth4g8nmWG+Ll4HT4XOXNoidvFz4UJRDZeD8AqK1IuQrM2fR8zAdNnQgC0PiGtlPIznlh1C16DWGbFMZIfZc3FB+4jKY0n4lRmOTJpejRs8uLT4CTr1/aX3lOx0BrpoXOVSvVT1WyMuVROloUaArD+bAkDhIap+L5QY2RA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RNPYUIrBLsMMxVTdAzewg07j62IbkGtj6dDVQnrzoS40esumA6B24qXVuHaBr5gzVJefDEAH34VIq4U2+FAP5O+CTYIudvrTIxvlZkqoy5kXXa1GWSR+Qviera4i0N6JsaNBlIcf1dCTQQkUXkkObrW8cRHA9mEFs1IBF87F5/OsGID6QXT8yl2fk+Z1gsabstjrEBolHicxIdkNNiNbnbQ+puSd2JFY1Wr1UjCZG6MnjRyOhMfNGfhJZS/aZhCV36thcAsSJOQAQ1IyKY06LabaGurTwugRptoXLLqytgPJ+oXYrseC+6f1wd0Q6oaKgIQfKLm0oyGs1IMfyb7GMg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Tue, 20 Jun 2023 11:41:12 +0000
- Ironport-data: A9a23:jpBRNKKAyGPRIRBIFE+R8pQlxSXFcZb7ZxGr2PjKsXjdYENS1DRWz GAeWG/TO/vYMTTyL913Ody08hxXv5PTz4JiTlBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrbwP9TlK6q4mhA4AZmPakjUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c4wRn1gy OcpMgs1axel3bmaypGYFNNz05FLwMnDZOvzu1lG5BSAVLMNZsmGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTGMkmSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHqhAdNPTuPjnhJsqASs4EURJQExblThnNfpyR+MWe8DE GVBr0LCqoB3riRHVOLVTxC+5XKJoBMYc95RCPEhrhGAzLLO5ASUDXRCSSROAPQ5sOcmSDps0 UWG9/vrCiZoq6a9Um+G+/GfqjbaBMQOBWoLZCtBRgxc5dDm+dg3lkiWEYglF7OphNroHz222 yqNsCU1m7QUi4gMyrm/+lfExTmro/AlUzII2+keZUr9hisRWWJvT9XABYTzhRqYELukcw==
- Ironport-hdrordr: A9a23:oKTiM69ZCqgTnFAA0xpuk+DwI+orL9Y04lQ7vn1ZYhZeG/bo7P xGUs5rrCMc6QxhIE3I/OrrBEDuewK4yXcY2/hyAV7mZniEhILKFuBfBOnZslnd8kTFn4Y36U 4jSchD4bbLfD9HZKjBkW+F+hUbrOVvMprEuQ4T9RhQpMhRBZ1d0w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/06/2023 2:10 pm, Roger Pau Monne wrote:
> Introduce a local xc_cpu_policy_t and use it to simplify some of the
> logic in the function:
>
> * Populate the introduced xc_cpu_policy_t with the current domain
> policy, which will already be the default for the given domain
> type. This avoids fetching and processing any default policy.
I'm afraid this isn't accurate.
Right now, xc_cpuid_apply_policy() is idempotent on a domain, but after
this change, it's only true for the first call after domain creation.
I can't remember if we depend on this behaviour right now, but my gut
feeling is that it's going to become more important as we gain more
opt-in features.
~Andrew
|
