[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH 05/13] xen/common: fixed violations of MISRA C:2012 Rule 7.2
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 20 Jun 2023 14:43:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ieumoWa5LOWImsRL0nsqxl3Nm+/VqJwvVssoBM819y8=; b=Eq/WibnX2wuOZR3RiKnxif18bNW8U+h6TDLiJD7nH8eyq1jM6xTeZa77trBbJqw8DP6y4B8nQIXzYkfkjJ4KWeMk2RWc013kORiDOmuKCHEPIdRbYyeyc82CSlTBECsvtID9cTQ5bgya1UFvZ/r1UGgfJVgK22raEM9UF24qWD9dbBGB6yg6Y1/UV1PDTXZJCPXD4EufVlaePuLhSrI59CB6rQZ+vQFHlIrXrt+v7NegEqpmQ06HoqzH9Zy7TPABgPNesYlG97QQI9WWUiVhcdrRh0VITaTAhFoOSbrSfb+BCy6hu0MskIrWWtXFvM2tMlroEpgxccTdZezc0nf1aQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nqCOSQbY6DjV/Aqd0/4b5EAoHlXBTiVnjwCeCfXlDz+sy+Y6q86i0mjDgR9BEfPZ/gx9rZwHEjYCoQpUAAcF8woVqKO37dyh2sD5PIjWL7Qq3VNrhAoDHyQqDHdtB3znUt8daktnBzl2c2k33RFsozuUtWIffFFsj4vqO7dszd6qVAzrSB3P0jzzKHBdc835jvXdd3p6K3ZVx9Okmv2CLLnsAhL5f+O/60Nw7dNk68K+ts8QJKiXb7ACyN7PUhDi3QR3mCaBHSvtm70+lt3a1IViqDrNFBvXzQqdP9baslB4aBfOG3ov/mAFXAyaA2KKPeli1j989Aa9ylojM3Korg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <Xenia.Ragiadakou@xxxxxxx>, Ayan Kumar <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 20 Jun 2023 12:43:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.06.2023 12:34, Simone Ballarin wrote:
> From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
>
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline
> states:
> "A "u" or "U" suffix shall be applied to all integer constants that are
> represented in an unsigned type".
>
> I propose to use "U" as a suffix to explicitly state when an integer constant
> is represented in an unsigned type.
>
> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> ---
> xen/common/device_tree.c | 4 ++--
> xen/include/xen/libfdt/fdt.h | 2 +-
> xen/include/xen/libfdt/libfdt.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
I think me and a few other people being on Cc here is attributed to the
(misleading) title. The set of touched files fully maps to "DEVICE TREE"
in ./MAINTAINERS afaict, which the prefix in the title would then also
be nice to express.
That said I'm not sure whether libfdt code actually wants touching this
way.
Jan
|
