Re: [XEN PATCH 08/13] xen/pci: fixed violations of MISRA C:2012 Rule 7.2

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Tue, 20 Jun 2023, Simone Ballarin wrote:
> From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> 
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose headline 
> states:
> "A "u" or "U" suffix shall be applied to all integer constants that are 
> represented in an unsigned type".
> 
> I propose to use "U" as a suffix to explicitly state when an integer constant 
> is represented in an unsigned type.
> For homogeneity, I also added the "U" suffix in some cases that the tool 
> didn't report as violations.
> 
> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>

Aside from the commit message that needs an update:

Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>


> ---
>  xen/drivers/passthrough/pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
> index 07d1986d33..95846e84f2 100644
> --- a/xen/drivers/passthrough/pci.c
> +++ b/xen/drivers/passthrough/pci.c
> @@ -990,8 +990,8 @@ bool_t __init pci_device_detect(u16 seg, u8 bus, u8 dev, 
> u8 func)
>  
>      vendor = pci_conf_read32(PCI_SBDF(seg, bus, dev, func), PCI_VENDOR_ID);
>      /* some broken boards return 0 or ~0 if a slot is empty: */
> -    if ( (vendor == 0xffffffff) || (vendor == 0x00000000) ||
> -         (vendor == 0x0000ffff) || (vendor == 0xffff0000) )
> +    if ( (vendor == 0xffffffffU) || (vendor == 0x00000000U) ||
> +         (vendor == 0x0000ffffU) || (vendor == 0xffff0000U) )
>          return 0;
>      return 1;
>  }
> -- 
> 2.41.0
>