[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: Drop opt_pku entirely
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 21 Jun 2023 09:37:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EvIT58V+xKK+dwMjcJKjNZS1UgUeGFEnreN1wDt/KGQ=; b=VAA9yoagcfCxpqwgUhrlfMVbCLUPbYxk4Lis9Z06yXqI4Sb4lO/7UAlFJbcFtD0fK/4Hf4geitunh5Rws/eoB+z1mF2VlHhAs/4mCyktV6Ldt7+y4gZFHXLaJU+m1nzdWZ+oBw+qZQcrpNTfYHg/hGJ7k1oDA4wni46U/r8edj7G5AxZkLbmXpEO4IjFkUiSR1GnxQxSi+9aEDazdfTmcQDfcW7T/8x27NxsVKGdVnyt8T0YT+w3TKPyFzRfnqArjOGMK0MecLftJNnj2vzVUfyJKtV7B3Bq5qR3Sq9rC7GKFtX5cOutVkXzq3bOWAM2Rcq37gryXk9IfZ3X2Z6Njg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MbdCG2AldNJY3vGUEcmUDiKB9vsQO1iQHUkyycDkWZFKYbP7vOwWY9JxTZkhz3gVNAfwoskPR26omo13HMlh0K0Vrq9ZLqxI82EcaiNEZpd4nEtYZ6VTGzYdsly4/B30LSBY/kr6/UmAcOIr7vIEXFV98ncKXOVlEVEYSERJ5qC7qw7SHnVg5YYy69OIww5S1UYOVnpI/bo/tgLRGFMFJKsBjyiYf9ZsjwovyDvx5XyHx1yqx4L1xfnfi9oFdYN80lOTidA0FY9Rbk3I6J33AvYLDWnIJInK3GpyQngJazyPvJCkgrY+bnYXQoo6zfaEgn0tFa5D+qgMWin2Z5B/NA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 21 Jun 2023 07:37:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 20.06.2023 19:47, Andrew Cooper wrote:
> --- a/CHANGELOG.md
> +++ b/CHANGELOG.md
> @@ -25,6 +25,9 @@ The format is based on [Keep a
> Changelog](https://keepachangelog.com/en/1.0.0/)
> - Add support for AVX512-FP16 on x86.
> - On Arm, Xen supports guests running SVE/SVE2 instructions. (Tech Preview)
>
> +### Removed
> + - On x86, the "pku" command line option has been removed. It has never
> + behaved precisely as described, and redundant with "cpuid=no-pku".
Nit: Missing "was"?
> --- a/docs/misc/xen-command-line.pandoc
> +++ b/docs/misc/xen-command-line.pandoc
> @@ -1950,16 +1950,6 @@ for all of them (`true`), only for those subject to
> XPTI (`xpti`) or for
> those not subject to XPTI (`no-xpti`). The feature is used only in case
> INVPCID is supported and not disabled via `invpcid=false`.
>
> -### pku (x86)
> -> `= <boolean>`
> -
> -> Default: `true`
> -
> -Flag to enable Memory Protection Keys.
> -
> -The protection-key feature provides an additional mechanism by which IA-32e
> -paging controls access to usermode addresses.
> -
> ### ple_gap
> > `= <integer>`
Elsewhere you said that we kind of imply that only the explicitly named
sub-options of cpuid= are supported. If that's the case (which could do
with saying more explicitly), you will want to add "pku" there in order
to not regress what is (deemed) supported.
It also looks as if the speculation control related enumeration there has
gone stale / is now incomplete.
Jan
|
