[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init



On Wed, Jun 21, 2023 at 11:09:57AM +0200, Joel Granados wrote:
>  static int __init random_sysctls_init(void)
>  {
> -     register_sysctl_init("kernel/random", random_table);
> +     register_sysctl_init("kernel/random", random_table,
> +                          ARRAY_SIZE(random_table));

As mentioned before, why not just do:

#define register_sysctl_init(string, table)     \
        __register_sysctl_init(string, table, ARRAY_SIZE(table);

or something like that?

That way no callers need to change AND you prevent the size from ever
being incorrect?

thanks,

greg k-h



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.