[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Updates to Xen hypercall preemption
- To: Andy Lutomirski <luto@xxxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Borislav Petkov <bp@xxxxxxxxx>, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>, the arch/x86 maintainers <x86@xxxxxxxxxx>, "H. Peter Anvin" <hpa@xxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>, "moderated list:XEN HYPERVISOR INTERFACE" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Per Bilse <Per.Bilse@xxxxxxxxxx>
- Date: Wed, 21 Jun 2023 19:05:41 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hFoiIgauJUdisXUuZZGm5A44v/YRCSGze0db1HjeRJQ=; b=RsQWDI49pAVmjDsIQYpHwSim6lz9n5RQQOgmUucrZZnVJLl+bhDyv0iNYAas3fYYce87zmOFZwAY8O2SzW9nnXFG003Mu07QloqBy3v3QJ4ORWx0Hl3GnPSiR3gqntrrcoGv9f0WIZsV93a+SUZzOJ0sT2iJz0xKH/qjQmeLy9RYcFUKnUoYDxpQPXAypvsNnHIghbTy/0OHjiWoR5lvsBrjL1wvBKFEhw/94kfH58ZJQv41KJ5v5+x3j35AG41EZI5HzsP3NsF+EZkjfX1HgleLGQvZm8PhbcRUhQYmKiFi5BpZEhGFnFgLmQwHBxQE9BfAzsnoV/6BMD+I6wdgbA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZS0JJXPNRvaxgmj2URS2ceSQH/59eCUTCNYW+5trYmgasLLiYJAzkjc6A4NKBGKbbq+12OUE8+mrewBZioQSmdzif3sUBmkTvkVNvuxeFcE4VG2CpjZNrHvThtehQCBfe/B8kHziN9JT/hppeWHXiexdimSdgVMYKdMo6CSbpiWkfTSYZHYlVqMA64ZkTFkl05tixlgFynhU7EwXV3ZlmcVttFytwj8cKDY8XUeww6gfMRLaswo8icNo/j8ehcg40ZPClUIT5hmTUjI+vKlAVur6EYKkhiV2L0FFQIIRS1ON3faoZTnJTp+IjapRXkdctlKjLXGXdf7RjMpvSktApA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Wed, 21 Jun 2023 19:06:15 +0000
- Ironport-data: A9a23:089Cda8RQnYKEp6jaewZDrUD6X6TJUtcMsCJ2f8bNWPcYEJGY0x3x mYYC2uEb/beZ2unft1+a4+y8E8H75aBz942HAs9riA8E34SpcT7XtnIdU2Y0wF+jCHgZBk+s 5hBMImowOQcFCK0SsKFa+C5xZVE/fjUAOG6UKicYXoZqTZMEE8JkQhkl/MynrlmiN24BxLlk d7pqojUNUTNNwRcawr40Ird7ks31BjOkGlA5AdmO6oS5AO2e0Q9V/rzG4ngdxMUfaEMdgKKb 76r5K20+Grf4yAsBruN+losWhRXKlJ6FVHmZkt+A8BOsDAbzsAB+v9T2M4nQVVWk120c+VZk 72hg3ASpTABZcUgkMxFO/VR/roX0aduoNcrKlDn2SCfItGvn9IBDJyCAWlvVbD09NqbDklcq cQzLx0ScCyOivOy36qmdLg8q9gKeZyD0IM34hmMzBn/JNN/GNXoZPyP4tVVmjAtmspJAPDSI dIDbiZiZwjBZBsJPUoLDJU5n6GjgXyXnz9w8QrJ4/ZopTWNilUujdABM/KMEjCObf1YhACyp 2bd8kzyAw0ANczZwj2Amp6prraWxn2rBtpDSdVU8NY1oVqUl09CDyY/fmaYg/yIsRCHAetQf hl8Fi0G6PJaGFaQZt3gQxqQo3OeuBMYHd1KHIUS9A6J2oLQ4gCEGnIDSD9RLtAr3OczRDol0 XeTkt/pDCApu7qQIVqX7p+dqTK/P3hTIWJqTSMNUwZD49Dlu4w1phbOSMtzVq+zktDxXzr3x liivHhgr7Yel8gG0+O851+vqzK0r7DbXxIy/EPcWWfNxgF2fom+fKSz9EPWq/1HKe6xVUKdt XIJn8yf6uEmDpyXkiGJBuIXE9mB4PKIMybVh1J1KIUw7DSm+3Olfod47Sl3IQFiNcNsUTvoZ lLD/ABc/pleOFO0YqJtJYG8EcInye7nD9uNfuDZaJ9Cb4Z8cCeD/TpyfgiA0mb1ik8unKojf 5CBfq6R4W0yDK1myH+9QL4b2LpynyQmnzqMGNb80git1qeYaDiNU7AZPVCSb+c/qqSZvAHS9 NUZPMyPo/lCbNDDjuDs2dZ7BTg3wbITXs6eRxB/HgJbHjdbJQ==
- Ironport-hdrordr: A9a23:HoAorKNeQKvq8MBcTsSjsMiBIKoaSvp037BL7TEWdfUxSKelfq +V7ZAmPHPP6Ar5O0tQ/uxoWpPsfZq0z/cci7X5W43SPzUO01HYSb2Kg7GSoQEILBeTygeN78 Zdm/kXMrPN5QYTt6nH3DU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZpFMl91hHG7ZDuUq21h7QjP0mVK+VceeAgAAsYgA=
- Thread-topic: [PATCH] Updates to Xen hypercall preemption
On 6/21/2023 5:27 PM, Andy Lutomirski wrote:
> This code is a horrible mess, with and without your patches. I think that,
> if this were new, there's no way it would make it in to the kernel.
Hi Andy, and many thanks for your frank assessments. Generally, this
is indeed somewhat old code, first introduced in 2015 by way of commit
fdfd811ddde3. There's more information in the notes to that, and it's
maybe worth noting that we're not trying to introduce anything new,
merely fix what various commits since then have broken.
> I propose one of two rather radical changes:
>
> 1. (preferred) Just delete all of it and make support for dom0 require either
> full or dynamic preempt, and make a dynamic preempt kernel booting as dom0
> run as full preempt.
Personally I think that's a good idea; a machine so limited in resources
that a fully preemptible dom0 kernel would be a problem wouldn't work as
a Xen server anyway. Having said that, what to do about this isn't
really in my hands; the issues came to light because the kernel for
Citrix's XenServer product is being upgraded, and it was considered in
everybody's interest to upstream the fixes. I'll see what I can do.
Best,
-- Per
|
