Re: [PATCH v2 6/6] xen/riscv: move extern of cpu0_boot_stack to header

[Alistair Francis <alistair23@xxxxxxxxx>]

On Mon, Jun 19, 2023 at 11:35 PM Oleksii Kurochko
<oleksii.kurochko@xxxxxxxxx> wrote:
>
> Signed-off-by: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
> Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Alistair Francis <alistair.francis@xxxxxxx>

Alistair

> ---
> Changes in V2:
>   - add Suggested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>.
> ---
>  xen/arch/riscv/include/asm/mm.h | 2 ++
>  xen/arch/riscv/mm.c             | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/riscv/include/asm/mm.h b/xen/arch/riscv/include/asm/mm.h
> index 3f694a43ef..085eaab7fb 100644
> --- a/xen/arch/riscv/include/asm/mm.h
> +++ b/xen/arch/riscv/include/asm/mm.h
> @@ -8,6 +8,8 @@
>  #define pfn_to_paddr(pfn) ((paddr_t)(pfn) << PAGE_SHIFT)
>  #define paddr_to_pfn(pa)  ((unsigned long)((pa) >> PAGE_SHIFT))
>
> +extern unsigned char cpu0_boot_stack[];
> +
>  void setup_initial_pagetables(void);
>
>  void enable_mmu(void);
> diff --git a/xen/arch/riscv/mm.c b/xen/arch/riscv/mm.c
> index 663048c783..602b89aeed 100644
> --- a/xen/arch/riscv/mm.c
> +++ b/xen/arch/riscv/mm.c
> @@ -20,8 +20,6 @@ struct mmu_desc {
>      pte_t *pgtbl_base;
>  };
>
> -extern unsigned char cpu0_boot_stack[STACK_SIZE];
> -
>  unsigned long __ro_after_init phys_offset;
>
>  #define LOAD_TO_LINK(addr) ((unsigned long)(addr) - phys_offset)
> --
> 2.40.1
>
>