[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/2] tools/console: Add escape argument to configure escape character
- To: Peter Hoyes <peter.hoyes@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 22 Jun 2023 16:07:44 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2gSL1txpX0lFBT1N9PYJXbgqpEj4i8eshcd5Rqeqfow=; b=hS3On+Mzsz2AhvWbp99iU5avEi8IAxdgktkwS+V64CVjfSgwc8uJ8lMH0NRTp5D9PZoArfOvq9KHRE64jlJGW9QsoImSToK3ySEGNnB8UAGaG2rRNtz7uwOXWztPvxMq/yox1NiOmxBIadzNCYquiiOpUQAx8V6cufmior9yWC/L2toYUjX2tSXw9MmiQXC8B7DwE1drY8NsM9oV+6GjdLsdF0q5ubZLmVPbJJTojhfXQ2FSrWMWNcdNFI9EFTyvAmZs/E9rX7CXlYn5OB/p34qULH3NRWHPb+6YR6GdguCOReAzqHQf/yIVzTkcMbM+LZQ3gD7odSAnfIGKQmnPSQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=haEcsdA7MqwhYbJUCTP0w19kKnnosStkcDxdzpUpmyKaH6yh3NJvxkv16A9tpOo0RquqiZ/V5nJVwKpTCbl/MNk6SUojxK6F6O0q2X9sW/oiv1apAAeoV7/mpkJtbDIx1NBbZ3OUBgD6o0zB0f4KdDhfV+Fjq/bLtBtonEEZLWLdh8ean7l7kSPYaTnaJ71IQ0Y2NrJb9O7d08bUcG77jaYzLaAu3Nx5Ewd7VpFEFobstdq3LnnYPb6rcioe029CnlXZs8oAwyYm2qE3s9SyUQCu9UoTbPhTtpJHMDOXcwU2f97zkMGcy6e28zIQFenYB2VGKCKlNO4Alo2NmkxAJg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: bertrand.marquis@xxxxxxx, wei.chen@xxxxxxx, luca.fancellu@xxxxxxx, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 22 Jun 2023 14:08:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2023 15:55, Peter Hoyes wrote:
> From: Peter Hoyes <Peter.Hoyes@xxxxxxx>
>
> Dom0 may be accessed via telnet, meaning the default escape character
> (which is the same as telnet's) cannot be directly used to exit the
> console. It would be helpful to make the escape character customizable
> in such use cases.
>
> Add --escape argument to console tool for this purpose.
>
> Create parse_escape_character static function to convert a character
> string (which may include a '^' modifier) into an ANSI integer.
>
> Add argument to getopt options, parse escape character and pass value
> to console_loop.
>
> If --escape is not specified, it falls back to the existing behavior
> using DEFAULT_ESCAPE_SEQUENCE.
>
> Signed-off-by: Peter Hoyes <Peter.Hoyes@xxxxxxx>
> ---
> tools/console/client/main.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
Short of a cover letter, replying here: What has changed from v1? This
then may or may not explain why Luca's R-b aren't here and in patch 2
(anymore).
Jan
|
