Re: [PATCH 3/4] xen/ppc: Implement early serial printk on pseries

[Julien Grall <julien@xxxxxxx>]

Hi,

On 22/06/2023 19:54, Shawn Anastasio wrote:
> On 6/22/23 11:43 AM, Julien Grall wrote:
> > Hi,
> Thanks for the response. I had one more question with regards to the
> emacs footer.
>
> > All files usually have an emacs magic block. E.g.:
> >
> > /*
> > * Local variables:
> > * mode: C
> > * c-file-style: "BSD"
> > * c-basic-offset: 4
> > * indent-tabs-mode: nil
> > * End:
> > */
> Is this absolutely necessary to include? The CODING_STYLE document seems
> to imply that it's optional and a quick peek at other architectures'
> code suggests that this is the case.
Interesting, I thought the coding style would impose it because from 
past discussion it seemed that we wanted to use it everywhere but it 
tends to be forgotten.
> If it is required, should it also be included in assembly files, or only
> .c/.h ones?
I think it shold be everywhere. But given the CODING_STYLE is more laxed 
than I remembered, then feel this to ignore this comment :).
Cheers,

--
Julien Grall