[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/4] x86/microcode: Ignore microcode loading interface for revision = -1
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 23 Jun 2023 09:27:50 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nnglgTf45V6XR3g53Zj4fKPBR5Jp8KXD+x4sO2CjuwM=; b=GaWBGZtaWTOprtAtO958rGktwklXKMhaTebBWnucGxo84kCvfjpfHga274ogIdwqjRHrIfR2KQDIuyFAKI5uCejtnB5RT2Xft40pC3d+ntsJ8oBRbMa1H8gdpguurd+9A3kId8ZiHKv2peJO4JKUmseJxStG1o2LYHiMMclfcEAqsqfMqJ6zMM2zThykdlTf8WDs1DDjRsELFnP4BhBniXZd3x9XbQhIp1amsxX/qwuVvY23gHjoq828Qfn+MqOiY9Pd/CkXoUVXaGnK0QQ+BTfHBlQ+/7HN7fBjfeWLXWWmL1AoPEXdlwkO6RSg+fyoMYJaZ2XTzITQAeAuKwO+7w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K5Gc1cj1EwItcZ6/Ee/TgZ+8mKgUE5m1iTBkV1FIXNqG+Cn/9xwVnpFQtzpXjBfyWqivl4w8sLw3bToF5fIN2ZttgAP1PFTibXcvH2Fe9CgqS3OVKGnTeJxcmD3duyxUbHF1+CqbXTNcB51+bfbfwzY4YZdzDAnikPBWCVLGH7CHF082+/UZPN20Mg5jONcdVhtOfgzgwGjgm2o4AU4BfganGo8a/Ig4MeCrRaqrsSrrwtK8kRO6aQ+TobMucS5gRP4v7vcA6OsDYrDSSGmPFz3TSvjcmvZjQiRRsoT2ZKhGHOqvy4Wv6crwChdHMbtujP1AnvSg8pAdj0GVlp3pQA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 23 Jun 2023 07:28:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2023 19:42, Alejandro Vallejo wrote:
> --- a/xen/arch/x86/cpu/microcode/core.c
> +++ b/xen/arch/x86/cpu/microcode/core.c
> @@ -867,10 +867,21 @@ int __init early_microcode_init(unsigned long
> *module_map,
> return -ENODEV;
> }
>
> - microcode_grab_module(module_map, mbi);
> -
> ucode_ops.collect_cpu_info();
>
> + /*
> + * Some hypervisors deliberately report a microcode revision of -1 to
> + * mean that they will not accept microcode updates. We take the hint
> + * and ignore the microcode interface in that case.
> + */
> + if ( this_cpu(cpu_sig).rev == ~0 ) {
Nit: Style (brace placement). Can probably be fixed up while
committing, if no other issues arise.
Jan
|
