[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 1/5] build: define ARCH and SRCARCH later
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 23 Jun 2023 09:51:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F+JD3XYDEbQG0NNV9SwSP343kenoSRjX3LSyK6XyEbo=; b=ECUDcE7ijNQGopqXe33oH1VXRlMiedKlG8olo+BasR5atJkBHcqPN5Qn1Fwl9muUyfHl3WGwKjmVBoGYr6wufrWv95gzcJZ/HCxts1Kn4CEdqsG4G639pTih6aMaIMBcmYv6ohg+lybtaVpBSSBOOu3VPhq6XyGAudPW6Q91DTvxr94GcpYKMsaCt+AMB/cHEqrG8NJn+BBEIB6j5Sm6osxBjEd16V7rpM93EvxSziYxRcITVj6vpD/4/DPIf8SuTfNBKg3ejsC80E7gXnQ8Xx3Ewdzq1gJX4tt1a7tGhylGfG9fhLfL5orT7GpgEMrqFM1YMV+AmHQeZXjBaYmD+g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkOX1mlBEHmmD8gGzBOrB3BEW/z0PrhvMvu8KnWwiFEfAMGgGpvCR0h+5SUvw5mfCoasOxxlad/f1sqgCqKyHA0HNeTN6di+xLrIGf33uUl1jL7G5rXa8NPG/Yw1XkVVzBe4uzc1Vilejr/5NJTD4/h/J95Kau/3mfU+FBgk/lY8Uj0gUf/QuiYgHAhulK7wDCrnu8f7PZonRxU36FmSDCvPtJXcIqZHTaVHuIK3nQrwlaIDWGceozz3z2B0Goh2tJ/1z00hTkJ/y5A7rhOH5qRveQCcUcy6opq7cceeT6A3RyTjg/v1m01fTnd2sklmZtIizI+DDNZYPQMKYuUuAA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jason Andryuk <jandryuk@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 23 Jun 2023 07:51:36 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2023 17:30, Anthony PERARD wrote:
> Defining ARCH and SRCARCH later in xen/Makefile allows to switch to
> immediate evaluation variable type.
>
> ARCH and SRCARCH depends on value defined in Config.mk and aren't used
> TARGET_SUBARCH or TARGET_ARCH, and not before it's needed in a
> sub-make or a rule.
Something looks to be missing in this sentence. I first thought it
was merely a "by", but I don't see how TARGET_{,SUB}ARCH matter
here.
> This will help reduce the number of times the shell rune is been
> run.
>
> With GNU make 4.4, the number of execution of the command present in
> these $(shell ) increased greatly. This is probably because as of make
> 4.4, exported variable are also added to the environment of $(shell )
> construct.
>
> Also, `make -d` shows a lot of these:
> Makefile:39: not recursively expanding SRCARCH to export to shell function
> Makefile:38: not recursively expanding ARCH to export to shell function
>
> Reported-by: Jason Andryuk <jandryuk@xxxxxxxxx>
> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> Tested-by: Jason Andryuk <jandryuk@xxxxxxxxx>
With some suitable adjustment
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
