[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v2 4/5] build: evaluate XEN_BUILD_* and XEN_DOMAIN on first use
- To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 23 Jun 2023 10:07:02 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K50uk+KgZD6sgl5v5QAF5/v6VfhZfN97VSZaBiXdcdI=; b=QaNWTQmisTRwxOQIAy1M95Gta6X1Ker0bJnTt+OvsS3q7R7knJGDJNRlwBw28q9vJUYDj3s+xhM4HWy9cC8khnGUnbIwwVPZIVbd0xwWr4oexfba6XjwjgEM2M+hr1Q4iF7x8yggt0sJjseWZjUcV0spBanjqYoRIaT48zZdgrzSi93AaIcyJ8BYdSbI3Z2yYjy0fNkq1YLMDTApM7s+sHkWJTGGw9I+rq/82NO7Z9moioPrdoZVgyC0Ew2xiv4uoKTy8V4B1AhWy4W2M1B7ywPyex/k+XFQjLzRXhIhAJBUUWZP0Zu7FCtnfuT/Cuqvyc9bs5bD+Q8SLrpIX2ZP6g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AhgVaiF/RoEezvBYgNMU/o8wy5frBJ94LNAPYlygXOw5SKEA70vJJBkfXGyxiP5WakRwwugYCbD+dax3+Any5MxVQOYqU6wYYCd7a+0leRMeTr3Tngl9eANJ719MtDAS+sAIZjYlJFbTY4igE0AkRUfIAMV3Z4qMqvge2z9661FdQRD7ZUSUSY7KRzVAKbRM1pwmygZjey/K7Mt2yiJtoXVHpyH/kyadj0FvNzoTpHJDCLmP7Z2MGAmwmh6gTSPdEmdAkcEwsRueW58cpCeiyhtnm/OMDgi6erLTr4PCV4jw6ozIoVOccQDaixt2jyP0q74pGqvsVR202nNMURXwjQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jason Andryuk <jandryuk@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 23 Jun 2023 08:07:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.06.2023 17:30, Anthony PERARD wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -11,10 +11,10 @@ export XEN_FULLVERSION =
> $(XEN_VERSION).$(XEN_SUBVERSION)$(XEN_EXTRAVERSION)
> -include xen-version
>
> export XEN_WHOAMI ?= $(USER)
> -export XEN_DOMAIN ?= $(shell ([ -x /bin/dnsdomainname ] &&
> /bin/dnsdomainname) || ([ -x /bin/domainname ] && /bin/domainname || echo
> [unknown]))
> -export XEN_BUILD_DATE ?= $(shell LC_ALL=C date)
> -export XEN_BUILD_TIME ?= $(shell LC_ALL=C date +%T)
> -export XEN_BUILD_HOST ?= $(shell hostname)
> +export XEN_DOMAIN ?= $(eval XEN_DOMAIN := $(shell ([ -x
> /bin/dnsdomainname ] && /bin/dnsdomainname) || ([ -x /bin/domainname ] &&
> /bin/domainname || echo [unknown])))$(XEN_DOMAIN)
> +export XEN_BUILD_DATE ?= $(eval XEN_BUILD_DATE := $(shell LC_ALL=C
> date))$(XEN_BUILD_DATE)
> +export XEN_BUILD_TIME ?= $(eval XEN_BUILD_TIME := $(shell LC_ALL=C
> date +%T))$(XEN_BUILD_TIME)
> +export XEN_BUILD_HOST ?= $(eval XEN_BUILD_HOST := $(shell
> hostname))$(XEN_BUILD_HOST)
Interesting approach. It looks like it should be independent of make's
internal workings, but I still wonder: Is this documented somewhere,
so we won't be caught by surprise of it not working anymore because of
some change to make's internals?
Jan
|
