[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/9] xen/arm32: head: Don't map too much in boot_third
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Mon, 26 Jun 2023 13:30:46 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9eoC6BRxpy61KJY+ez9tmSMIB3a1ZQz02pGHY6ypFJ8=; b=Gtvh0k7KSM1nzChTLGl+vUL+6o8LR7xt5ciIUSyzW+ovZuDh8TptNeraBGq1WIn18SeIUrIlcColpC2hbf/V6J24GXOiu+5flzXxsHjIB1vJ8OBwMoSpzsrBuPC0fdR5nNk5SsheF4chrmvn5qfImbsERZKyO72KM02B/GrW7v2EkZWj68NXdosG9KEs0Co4F++KJu2ya9jr2/DdLZ5az8ICMejzptWYfmImT5woJMYuqPFx1AX43TSLnB9C/h72y5MtzOlQp/V024uRDDl7Y8TounYsPUn8p4Y9Xb7QLZELG45+/LKXBQ1CuQ04SP5SPIG1+S2Xh95S0JDHkX/cpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fLwEFL/SdpAUgdugWglQKntKT6AnsU2UoBYif0QMNq1KNS9gXlU2ZWZ87A52CRLb2OHGacyXkPuLvfXzqJ0Yf75EUcrJ7SStHK4KEkHU/vcXJaC6ECYlVWozebAjJqEGWQadfsiDfKvzg7wxRqy1iqiQYEifxTeUW9hvZvdZJGjmJCn+V0Kee3QT7ZVb79CGCTdXhC+YDLJvg4oXkY6DhBTCvGoWUMIt7T8hcbw2hHNZcera409ogQBYwgKJjZ+LK/rT2EP3jrCkwOjpDNOWF+ZfLuFsjPj0qySOntZ9dj+koXZihJPYBv5Huzg5935JuMO6LPoMIaM8inXpZoHRXg==
- Cc: <Luca.Fancellu@xxxxxxx>, <Henry.Wang@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "Bertrand Marquis" <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Mon, 26 Jun 2023 11:31:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25/06/2023 22:49, Julien Grall wrote:
>
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> At the moment, we are mapping the size of the reserved area for Xen
> (i.e. 2MB) even if the binary is smaller. We don't exactly know what's
> after Xen, so it is not a good idea to map more than necessary for a
> couple of reasons:
> * We would need to use break-before-make if the extra PTE needs to
> be updated to point to another region
> * The extra area mapped may be mapped again by Xen with different
> memory attribute. This would result to attribue mismatch.
>
> Therefore, rework the logic in create_page_tables() to map only what's
> necessary. To simplify the logic, we also want to make sure _end
> is page-aligned. So align the symbol in the linker and add an assert
> to catch any change.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
The same comments apply as for the previous patch. But all in all:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
