[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1] xen/arm: arm32: Add support to identify the Cortex-R52 processor
- To: Julien Grall <julien@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Ayan Kumar Halder <ayankuma@xxxxxxx>
- Date: Mon, 26 Jun 2023 19:17:00 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oeHXLEtbheAf+jFSN86qIDwoxCZcTUTBwyQiWyrKNnI=; b=It5d2T3i0OwubxPz4kS1Tpm2B1hOcQCSCv1aNa3i3WjCTFWbip9K40GsBHLIzbHl0p8Qnw3fEzPKtdpJFS1753At+j3Rf6oWK4KphtMHloQTEI3tavSrCV3tzFtDzs2TMjPtMXToB8UXdrP4tXTC2z9JT6QDdd1KGq4v8S4p9p2RkMzRWU0ejse0/W8l12zdoMTNJS8ZLOBSm4duE7wkZa5Hf5GEykVFlREfDkhn44HPZlpFrQNvg9XjdbgbcSANthal9SuMvtK3exjGh2AVjCud9zLlxD1ftUjDk/wTfs0mzY8/+6WmF+GALU/Uxq07RCe8RfyzsjPb4pLp4cN2Bw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gwk2IyBnTKtpf5qDF7Rg5Rpmi8IwwDjsGLaTCH2xzR1aJTvk5mMzwLDWlC9xtDf7X4CwKF8o5SkbZcbo48Y1tcCUVnpxJ7QZZJSWaYeIT8Az50Oqs+Du49XN4qJN3nZg63xJ6CHPSB6yfHVQxu6OGx+0GLJqKtMxPuqkjYv0yflcOhH6XM45kQYtOfE9Vvx6tgirqmWzO/PtdsjfNplpDPleB7ATHpmHgH6xnL0GFeYkfWqKnBZU8FGo7VZavukpTWsCZb3kyqp3wqskXIrMXkYwUAnJrFUUmwy+fHNrxpSnuH9y1dm3sVHemSn765JSVDOTSnCs6HN74RWRe0u9fA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
- Cc: sstabellini@xxxxxxxxxx, stefano.stabellini@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx
- Delivery-date: Mon, 26 Jun 2023 18:17:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 24/06/2023 08:04, Julien Grall wrote:
Hi,
Hi Julien,
On 23/06/2023 22:26, Julien Grall wrote:
--- a/xen/arch/arm/arm32/head.S
+++ b/xen/arch/arm/arm32/head.S
@@ -322,7 +322,7 @@ cpu_init:
PRINT("- Setting up control registers -\r\n")
mov r5, lr /* r5 := return address */
-
+#ifndef CONFIG_ARM_NO_PROC_INIT
/* Get processor specific proc info into r1 */
bl __lookup_processor_type
teq r1, #0
@@ -337,7 +337,7 @@ cpu_init:
ldr r1, [r1, #PROCINFO_cpu_init] /* r1 := vaddr(init
func) */
adr lr, cpu_init_done /* Save return address */
add pc, r1, r10 /* Call paddr(init
func) */
-
+#endif
I think it would be best if you just #ifdef the fail below. So if the
config selected, then you will still be able to have a Xen that can
boot Cortex-A15 or a core that don't need _init.
Note that for now, we should only select this new config for Armv8-R
because there are some work to confirm it would be safe for us to
boot Xen 32-bit Arm on any CPUs. I vaguely remember that we were
making some assumptions on the cache type in the past. But maybe we
other check in place to check such assumption.
If this can be confirm (I am not ask you to do it, but you can) then
we could even get rid of the #ifdef.
I had a look through the code. We have a check in the 32-bit version
of setup_mm() for the instruction cache type. So I think it would be
OK to relax the check in head.S.
Bertrand, Stefano, what do you think?
As per discussion, I have sent "[XEN v2] xen/arm: arm32: Allow Xen to
boot on unidentified CPUs" with the comment addressed.
- Ayan
Cheers,
|
