[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] xen/arm32: head: Remove 'r6' from the clobber list of create_page_tables()
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 28 Jun 2023 10:12:45 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ytMUx1H7ss0hd3UytxPThLf5zo6q5W6W3wvb57CT95c=; b=j81gRI3ZF+CnIT2/fjuDACN+QWpZBWYf4E50/MLEDA7VNdsAMPrLIZCgcToUWzLgPuSwOf97h8ACS745zm6ExZGDo/kfhJ4LHOaXwRDlQAta3rLLgjsRtJe5xOkI3LyI+sQdrRQ5Ki22oxl++K71sR1L99QsSwhql6NUzFEE1lPC8F7Mf5HB1q1oQK/2b2GXLQHFERdJLLjJoJHpJDjtGEGBhXKalW4tZ3IYnaBppy2owDPIIjibO34PT46j/rVCwCHXbS8rNBhl39sR5RY4KVbJ5L3JNMP1+k9vAX4c6wD5xMcRqeHg2/UDrh72TJqoquA7BgkGYLD+I8TtC4lBsg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AzTBrVVC4bmnj+4D8vZBaCbPq5/Jf/ApXCjwXAIfwhPVgrqGEi1HQOFs0Kdq6qsrm2wrjRCvHRWgf2KoHxK2DXf9jPqWRSVEtCxQGJbRuTA09st1ZI7XqL9D/7XLuy+sZuFGsJ16u+Re7Kln6sqjCwQJaSl3vuJJZ8Ch63wlszd4Ow65TDpPFbUab2peCeGFppdRV83WPkq5cR9y9yjcDm+5mJumYpHb9WL7lUuJkmkMauRQahOeG7T99k27LmiieLGKSCy9OlGN6uu6/qPGOL8O/kIrFAr99xvMcElLkvHM85c9BJiMXtk4ApPW0b2i+2ziJqkYfxm7TU5b24vxjg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 28 Jun 2023 10:13:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZp6aNAcSElr/BRUqZZ/p1BOWK86+gAs8A
- Thread-topic: [PATCH 4/9] xen/arm32: head: Remove 'r6' from the clobber list of create_page_tables()
Hi Julien,
> On 25 Jun 2023, at 22:49, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Since commit 62529f16c8a2 ("xen/arm32: head: Use a page mapping for the
> 1:1 mapping in create_page_tables()"), the register 'r6' is not used
> anymore within create_page_tables(). So remove it from the documentation.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/arm32/head.S | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S
> index 997c8a4fbbc1..5e3692eb3abf 100644
> --- a/xen/arch/arm/arm32/head.S
> +++ b/xen/arch/arm/arm32/head.S
> @@ -451,10 +451,7 @@ ENDPROC(cpu_init)
> * Output:
> * r12: Was a temporary mapping created?
> *
> - * Clobbers r0 - r4, r6
> - *
> - * Register usage within this function:
> - * r6 : Identity map in place
> + * Clobbers r0 - r4
> */
> create_page_tables:
> /* Prepare the page-tables for mapping Xen */
> --
> 2.40.1
>
|