Re: [PATCH v2 3/3] xen/types: Rework stdint vs __{u,s}$N types

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/06/2023 12:08 pm, Roger Pau Monné wrote:
> On Tue, Jun 27, 2023 at 08:56:18AM +0100, Andrew Cooper wrote:
>> Xen uses the stdint types.  Rearrange the types headers to define the
>> compatibility __{u,s}$N types in terms of the stdint types, not the other way
>> around.
>>
>> All all supported compilers on architectures other than x86 support the 
>> stdint
> Duplicated "all".

Yeah, already noticed and adjusted.

>
>> diff --git a/xen/include/xen/stdint.h b/xen/include/xen/stdint.h
>> new file mode 100644
>> index 000000000000..4cf82790f196
>> --- /dev/null
>> +++ b/xen/include/xen/stdint.h
>> @@ -0,0 +1,33 @@
>> +/* SPDX-License-Identifier: GPL-2.0-only */
>> +#ifndef __XEN_STDINT_H__
>> +#define __XEN_STDINT_H__
>> +
>> +#ifndef __INT8_TYPE__ /* GCC <= 4.4 */
> I'm possibly confused, but don't you want to use __INT8_TYPE__ if it's
> defined, and hence this should be an ifdef instead of an ifndef?

You're right.  I was too tired while putting this together.

Originally, this was going to be

#ifndef __INT8_TYPE__
#define __INT8_TYPE__ ...
#endif

typedef ...;

but decided to get rid of the intermediate and use a plain if/else. 
I'll fix.

~Andrew