[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: XenSummit: Empty per-arch files
- To: Juergen Gross <jgross@xxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 28 Jun 2023 14:46:49 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aNfJrvNrpuFW/ZssGos9i515PIxNEG10/+JpgklfQjk=; b=PI4GNdl6oFIIf4/JuvxMfWu/+9Myc70IdeUeWXL9AKRo3883HHFL8ctQXhqEXwTTdVm8626WgaKGXiC3uQlt3+k4/ZTVX1O/gM4dwcfuURF50NFkCzW9nES4uAbzW9I1q0cm0xs+OHMUUwM1bgfgeotqT0pGDOnUXzjH3onavSFi6gxYx/T5GaisGkoDfJg1u8H21ox0t4cEwhBgrcAxRHbY9Nk/qWHuCJvSZX5jaWoqTeEPm1x2+NuiNUQon0d+OsdGiwPN0TZ9WPWnouLkNeGk91bkFhOvrNUAPB8/98P+hJZ+1VqudTvriU+TlTFdv+sC+lnN3Q2Cgi1OOzRceA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WPGd/zr8ecwywcW4nQ6XFkQ2DvCqtuD3jWtV50/FgsleDWTw+kGIClA3s11enHs3ZDPpmEvAbRlTYYgteclyJxLJwXC6E4S9f/LWXZ9KVo9IIDLOHIHUAlJDv4lubCUCuqUyicQFHhcVVf0iFXgC3ERX7xn6HP2dvmXactLeFt6UVDKHN6OA6xqj43OFa6cIybq6UxRYiW9/QurP6MCsK9oxwma2Ef/0g4SyTnYHAKJVgkJ9Dx7o4Gctz/t/rcQFnwFifXIiI9Qf+yLOuQ4u8a7xEal6LSHXjzROXEWfOgs15a+KuZq7ZGeTXEgWOphmMDHq4HNPjFxxoDzUHp7jlw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Bobby Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>, Shawn Anastasio <sanastasio@xxxxxxxxxxxxxxxxxxxxx>, Timothy Pearson <tpearson@xxxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 28 Jun 2023 13:47:18 +0000
- Ironport-data: A9a23:fJzga640ILLyEnvduduZIAxRtBnHchMFZxGqfqrLsTDasY5as4F+v jAeUWvTbveIYzbzeY8kb4WyoE4O65eEn9M1QVc6pSw0Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35ZwehBtC5gZlPa4R7AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m+ fERdCJUXgq6mf+a+Im8CeRz3pUnI5y+VG8fkikIITDxK98DGMqGZpqQoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Nkkoti9ABM/KMEjCObexTklyVu STt+GPhDwtBHNee1SCE4jSngeqncSbTAdtORO3kq64x6LGV7jUeMjgTTleAmvWem3SwXtl2d GY+5wN7+MDe82TuFLERRSaQonGeuQUHc8FNCOB84waIooLE7gDcCmUaQzppbN09qNRwVTEsz kWOnd7iGXpoqrL9YXCX+6qQrDiyETMINmJEbigBJSMa5/HzrYd1iQjAJv54C7K8hNDxHTD2w hiJoTI4irFVitQEv4254FTGjjSEtpXPCAkv6W3/YGWh6Q9oYZ+/UKah41Pb8PVoIZ6QSx+Ku 31ss8KZ5uofAIqNkCGISeMlE7Sg5vLDOzrZ6XZmG5g66z2s4TitZ4lW6zBlDFhlOYAPfjqBS ETUvwVW5pNaInqxRaByaoO1Tc8tyMDIEtDoVevVb5xNf4J2fw+E+wlhYEeR2ybml01Eubo2P 56Abc+3DHEyE61/0D2sSuES0Lkmyzo/w2yVTpf+pzy7ybeXfmWST58fOUOSafo06qyFpgjY6 ddZOI2BzBA3bQHlSize8IpWKE9QK3E+XMrys5YPKrXFJRd6EmY8DfOX2akmZ4Fug6VSkKHP4 225XUhbjlH4gBUrNDm3V5yqU5u3Nb4XkJ7xFXZE0YqAs5T7XbuS0Q==
- Ironport-hdrordr: A9a23:tBZ+natiFwx/fTvc2nrfQtLJ7skDrtV00zEX/kB9WHVpm6uj+f xG/c576faQsl0ssR4b6LK90cW7MBbhHP1OgbX5Q43SOjUO0VHARO5fBODZslrd8kPFh4pgPN 9bAstDIey1N35crey/zSuZN5Ib4PehmZrDuc7ui01qSgFhL4FMhj0UNi+rVndxQwlNQb4Xfa Dw2vZ6
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28/06/2023 2:26 pm, Juergen Gross wrote:
> On 28.06.23 13:32, Andrew Cooper wrote:
>> Hello,
>>
>> This wasn't a formal discussion point at XenSummit, but Oleksii pointed
>> out that it was still a problem, hence this thread.
>>
>> As we take on more architectures, it becomes more and more important for
>> things to be handled in a mostly-common way. With that comes quite a
>> lot of <xen/foo.h> including <asm/foo.h>, and the arch one being a stub
>> in simple cases.
>>
>> It would be nice to get rid of the stub files; they're irritating to
>> deal with, both when refactoring and simply for the file bloat they
>> create.
>>
>> There are two options which come to mind.
>>
>> 1) Use __has_include(). This would be ideal, but would require us
>> bumping the minimum GCC version to 4.9.2 as a prerequisite. I'm not
>> aware of any way to emulate the necessary behaviour on older toolchains.
>>
>> 2) Have a stub "architecture" which is always last on the include path.
>> This would reduce the number of stub files from one set per arch, to
>> only one set.
>>
>> Anything else that I've missed?
>
> What about a make rule creating an empty include file if it is missing?
Wouldn't that cause a typo'd header file name to spring into existence ?
And it would cause a build to leave the working tree dirty.
~Andrew
|
