[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 05/11] tools/xenstore: rename do_tdb_write() and change parameter type



On 20.06.23 14:20, Julien Grall wrote:
Hi Juergen,

On 30/05/2023 10:13, Juergen Gross wrote:
@@ -395,18 +393,18 @@ static int finalize_transaction(struct connection *conn,
      while ((i = list_top(&trans->accessed, struct accessed_node, list))) {
          if (i->ta_node) {
-            set_tdb_key(i->trans_name, &ta_key);
-            data = tdb_fetch(tdb_ctx, ta_key);
+            set_tdb_key(i->trans_name, &key);
+            data = tdb_fetch(tdb_ctx, key);

This change confused me because you are just renaming the key variable. This feels unrelated to this patch (yes, I know that the variable 'key' is not used anymore). So I would rather prefer if you don't change the name.

Okay, I'll keep ta_key.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.