[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 28/52] xen/mpu: plump virt/maddr conversion in MPU system
- To: Ayan Kumar Halder <ayankuma@xxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 29 Jun 2023 15:23:20 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0MDxt2GgRK+2w85hTGFMTLyDMERe6l1HetjhK5vHRBs=; b=KuD1bFsrQN5ssNyeI2O7CP3d+3sECErutdcqURQN/cWMlQbLqfTKidI+EK61nlZFNXDsJf2N/pi+7rQW9ptaZzsFcGrjYi35E5z1sU1OkNqsQ0GqZJDmkhqUAVGrBefKk5mFFue4b2toQZ8GIsnBOJOerHke5wCtD7Bqg+d7KG5O4MXtB5NaDtUhpv2q0FuN6OvfTPAgYMQpFrD6eNmPJOj8joxgna/Wjm6JpM0rG9t2fDFK2QpeSWKRBAZXwGvzvGdwtiwa3nGjaJKur7n5opuh2CFLmZutbgkSlBL9lGXvFXZUAGD1hzJ79SCvwn6DReQeQTB9dw20xui7OiJ7DA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GnBsvaZQyC3R/AtdYp/TB2ouJLZUU/p/Rn2fD7Zt26bEdsvu7rwVYxVwSjxmJa5zr6EQ3HRzB79kO9tv531Orbgwd6Jv2GZbm/uB4XNoSNvZgpLd497r38516NhnDE4wsf7IixpX5wMLufpDQB243VuLab8/1ATo7i8Bj1yQKZ1OrfNG0sLgyj/ooVnyCas2mieXaoqhy1RpLXft2JJw5Uko8bXvayj5zfUdleqZ2veXeD7geLK1OSwtxoTIsJqM08B3pwe+2PlzVjJikl2aGhwf1gPsvvoHQ83LEvZ1ySaA671iIRcZA5fywm7c8pHyoqKJWNOBxdqrCiyGb8QeMg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Chen <wei.chen@xxxxxxx>
- Delivery-date: Thu, 29 Jun 2023 14:23:55 +0000
- Ironport-data: A9a23:0wfOP6K5iz14ahyhFE+RdJQlxSXFcZb7ZxGr2PjKsXjdYENS0GRVy mRLXGDSaKqJYjT2e41+b4W+9ENX6J6GnYBrHQFlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/rOHvykU7Ss1hlZHWdMUD0mhQ9oh9k3i4tphcnRKw6Ws Jb5rta31GWNglaYCUpKrfrawP9TlK6q4mhA4AZvPaojUGL2zBH5MrpOfcldEFOgKmVkNrbSb /rOyri/4lTY838FYj9yuu+mGqGiaue60Tmm0hK6aYD76vRxjnVaPpIAHOgdcS9qZwChxLid/ jnvWauYEm/FNoWU8AgUvoIx/ytWZcWq85efSZSzXFD6I+QrvBIAzt03ZHzaM7H09c5WWWwT1 vwiCgoBZyGSvsOKzeOLEfdV05FLwMnDZOvzu1lG5BSAVLMNZsmGRK/Ho9hFwD03m8ZCW+7EY NYUYiZuaxKGZABTPlAQC9Q1m+LAanvXKmUE7g7K4/dppTGMlWSd05C0WDbRUvWMSd9YgQCzo WXe8n6iKhobKMae2XyO9XfEaurnxHqkAdJKS+HpnhJsqGaP1jcVMRc0aXrlrPCGq0q0Yu1yd kNBr0LCqoB3riRHVOLVVgyxpn2Zuxc0Ut9cVeY97Wml8qfS5RffNGgJSDFpYcYj8sQxQFQCx lKP2t/kGzFrmLmUUm6GsKeZqyuoPioYJnNEYjULJSMe+MXqqow3ihPJT/5gHbSzg9mzHiv/q xiIsSw/irM7ncMNkaKh8jjviT+2uoLASAJz4wzNR3+k9StwfovjbIutgXDl6vJHIJecX0O2l nEOkMiD78gDFZiI0ieKRY0lA7yoof2FPTv0iERqWZIm8lyQF2WLeIlR5HR1Ix5vO8NdIDvxO haM4EVW+YNZO2asYelveYWtBs82zK/mU9P4SvTTadkIaZ90HOOawBxTiYer9ziFuCARfWsXY P93re7E4a4mNJla
- Ironport-hdrordr: A9a23:Amq8d67PDa6wmMSDXwPXwPLXdLJyesId70hD6qkXc3Bom62j+P xG+c5x6faaslgssR0b+OxoWpPwIk80hKQU3WB5B97LNmTbUQCTXeNfBOXZslrdMhy72ulB1b pxN4hSYeeAa2SSVPyKhTVQxexQpOW6zA==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/06/2023 3:20 pm, Ayan Kumar Halder wrote:
> On 26/06/2023 04:34, Penny Zheng wrote:
>> diff --git a/xen/arch/arm/include/asm/mm.h
>> b/xen/arch/arm/include/asm/mm.h
>> index eb520b49e3..ea4847c12b 100644
>> --- a/xen/arch/arm/include/asm/mm.h
>> +++ b/xen/arch/arm/include/asm/mm.h
>> @@ -292,6 +301,12 @@ static inline void *maddr_to_virt(paddr_t ma)
>> ((ma & ma_top_mask) >> pfn_pdx_hole_shift)));
>> }
>> #endif
>> +#else /* CONFIG_HAS_MPU */
>> +static inline void *maddr_to_virt(paddr_t ma)
>> +{
>> + return (void *)(unsigned long)ma;
>
> Why do you need "(unsigned long)ma" ? Both "unsigned long" and
> "paddr_t" are u64.
For when paddr_t really isn't u64.
The logic is correct, but it is an opencoding of the _p() macro for
turning an arbitrary integer into a pointer.
~Andrew
|
