[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH] xen/arm: grant-table: Correct the prototype of the arch helpers
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Fri, 30 Jun 2023 00:46:13 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hk0AC1RR/0yRhUanGPKRace5jssaaF2t07UhAg3FgKM=; b=ZdTIXS+6XWM8zPxVLkoD11LqOovj5XV548IQA1hMgbwm+ztaUB7FhexK6PF797Gvcascl9iuYrEBN3UMhP81AZ8fLdbT0MPyTA2ZgfuzxIqqA7iS+kwEhuISk2n2slCcdSr7ZKxkiKm1LrNfl0/RxMJK0xDKRNDodJn5I5w+y8vYodwlQgaLLNjHd1xQf8vn1/rSFVIEgoA7/Uq/2KIwG53eaZDJSCwnLQgnrDrjFLGh7RCuiE330pjWan0cyhFWmGhVtyEON17JoRnB4KRdL/DgqsNRyvr0nuR8HAYfrzd0lsWWPxgk0W56mIXk5CSV5diDjCRDQi7Yy7+MAS7FGA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mZ0PyY+gX/3UCsxWG7w0HZSFh9f/qOD4Saylw0Vj5+pd+vi8nh+rQpH06iKUJEQojHzQU4jD728biqLI5IXgu60jA56R4ZBgoKF5Qz8Cj4HWlmKGyoNu5MBaAIbhraZNETjjrnNySP5Pke61C7zQRxnFJwYOaJxW3655h8hukywYQf2j79/o15gBWtEQYDnNoTUFoCoellOmPe+i8hp+btHZ7hasYL2F2Zjuj6qpux+M6GHC44iXSSZUPzRRJ1s/enQLk1BGcJHrnKE2QrgWmmBS8Avpl+VO2KrnTDH7mUatA8vx0Eof1GewTlpVrFE6XbrrvKNXkVJpDJu3zETqkQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Luca Fancellu <Luca.Fancellu@xxxxxxx>, "michal.orzel@xxxxxxx" <michal.orzel@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, "federico.serafini@xxxxxxxxxxx" <federico.serafini@xxxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>
- Delivery-date: Fri, 30 Jun 2023 00:46:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZqsz3/pX1kq6zlkOe7xuFvx2f0K+iWuww
- Thread-topic: [PATCH] xen/arm: grant-table: Correct the prototype of the arch helpers
Hi Julien,
> -----Original Message-----
> Subject: [PATCH] xen/arm: grant-table: Correct the prototype of the arch
> helpers
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Both the stub and the x86 prototypes for replace_grant_host_mapping()
> and create_grant_host_mapping() will define the first parameter (and
> third for the former) as uint64_t. Yet Arm will define it as
> 'unsigned long'.
>
> While there are no differences for 64-bit, for 32-bit it means
> that the address should be truncated as 32-bit guest could support
> up to 40-bit addresses.
>
> So replace 'unsigned long' with 'uint64_t' for the first parameter
> (and third parameter for replace_grant_host_mapping()).
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Henry Wang <Henry.Wang@xxxxxxx>
Tested-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
