[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [v2 1/4] xen/arm64: head: Don't map too much in boot_third
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Fri, 30 Jun 2023 08:50:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NwEK+o9IwmrNuGgAXKPWmNm4XtTe/QRaK1RAAUpapcg=; b=lm6SyktPEJ+bJ1Cn8if1FT+kicjl5T1oXj5Rt/kJjHXGAd37he0jlavFPgrVovbie7h7XjofLgO2KyufAKa3IGJKpjV1mmGP9Ke6t6YS0NRLCKkJpbExDjGbzCZldwAkTKpgVaCRWxc3DuXcVThVXBvWDN7bEFvedhw3w7E/Dx2XuZMOqW9dEtraiDaAuAhpl/vYEbCdaW/5ydjXe46KPXkbliqounuoarphYX3JzWDpWnk9HSiJbeKlm8AGCe4Bjka0ZdH3Ws9e0F3TqnURGjj8TER9TtyRzUmRdwTf+UryJ03FQMe1l88kjhXEvC3x7+rFvh1/bmvQK3hFn+F7og==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ASBzq26sYXw+PzyLRzIgP+7wLlPFXmeqqXKPnoU4vizSUqefh35qGacHtK9YVhFSlZZcMWkLgeRfqhf8U81qNgSFZ7S9D/kkRP5afvXkGQjO6RIPRM7e0eeVvnhV5RPWeV6CxieulRwu3s3B1wIKMXlULmMCcMTbCeTrHCD5M69v7FvfzwiiqNNC1qfJ3M+dy4yp+4RUBEcCUkI5fLpLDyEFyj7HGyCaYxm/HHx4mzG6DdoY065kBgrVSqOKC67iTQaVdWPOkA7OnrO5YhBGEjO0yqHIipJmo7KH0WrkuwSSGonez7UAxlRM2AtJ94gsatgbJkJ9coV0nd2Pk1aoDQ==
- Cc: <Luca.Fancellu@xxxxxxx>, <Henry.Wang@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Fri, 30 Jun 2023 06:50:55 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/06/2023 22:11, Julien Grall wrote:
>
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> At the moment, we are mapping the size of the reserved area for Xen
> (i.e. 2MB) even if the binary is smaller. We don't exactly know what's
> after Xen, so it is not a good idea to map more than necessary for a
> couple of reasons:
> * We would need to use break-before-make if the extra PTE needs to
> be updated to point to another region
> * The extra area mapped may be mapped again by Xen with different
> memory attribute. This would result to attribute mismatch.
>
> Therefore, rework the logic in create_page_tables() to map only what's
> necessary. To simplify the logic, we also want to make sure _end
> is page-aligned. So align the symbol in the linker and add an assert
> to catch any change.
>
> Lastly, take the opportunity to confirm that _start is equal to
> XEN_VIRT_START as the assembly is using both interchangeably.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
NIT: it looks like other maintainers are not CCed on this series.
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
