[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [v2 4/4] xen/arm: Allow the user to build Xen with UBSAN
- To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Fri, 30 Jun 2023 08:58:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8dSf91cpV2ZlfMYs0xZvmcR8oOgsfgItiRHBCj0n0RQ=; b=BFCqPfELOaTjb9tdTAr3OAHVWmEHm5cZXZu8dtpfP2FKeRbaE3CnMzIO5LaXoPlJVHKXVm6HeSVh7OvK3WnZYz3RFI/eaU1XB9r5BWMLLhgsMY3SgxH/68IwcWMIPJI+1s+5GFsbir4NdAJfsX6dhKZrj3zWsYgTxgysKqhvvM7OXzkWPvlY6uNMZm5O9D65F40PQ6e1yRXJXMcT0HtYyEvLEH/oeIbfScV1aeS8c8k4bm7vqm5phM/eH/3CZFIbXGYzChb77tfPoXoRvqd63c9MuDgNLsRqkdJKNE8aTbyPa1v37XSr8TViqOezSKbdMfF3XD5ZgUbWA4YVnZ3gzg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XrMVDzUuwDe64R6EPbLA2qVjv3p+KkGSLSxgCrBS/FcDf6ZpfySMVo31p9kAybVwtatgOmAixS8rbQra2cBZS8AhCJwzaeTE4O4sY3vjfCepuqP44Cpejk1UXIzkeU+/n1X86Fmn0YwOkKTv+so7oCUF6m02k+TLYXEzglqYKjIY6PSfqpIHApcrXXzS1bJr7n0dAMT4s+FIjbRRK/9+pRcl5qtxAoAv0rKPzf6z+Airakh7k0hMDs4Y/sl6HBjCU6mTEFyQcB+VSVk4QblLTCCjoVlQhl7rydmyv/udm573hclsy28SOoBINwSWdwdqXLNOaht+srpuHNgK2lw9QA==
- Cc: <Luca.Fancellu@xxxxxxx>, <Henry.Wang@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>
- Delivery-date: Fri, 30 Jun 2023 06:58:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/06/2023 22:11, Julien Grall wrote:
>
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> UBSAN has been enabled a few years ago on x86 but was never
> enabled on Arm because the final binary is bigger than 2MB (
> the maximum we can currently handled).
>
> With the recent rework, it is now possible to grow Xen over 2MB.
> So there is no more roadblock to enable Xen other than increasing
> the reserved area.
>
> On my setup, for arm32, the final binaray was very close to 4MB.
> Furthermore, one may want to enable UBSAN and GCOV which would put
> the binary well-over 4MB (both features require for some space).
> Therefore, increase the size to 8MB which should us some margin.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
>
> ---
>
> The drawback with this approach is that we are adding 6 new
> page-table (3 for boot and 3 for runtime) that are statically
> allocated. So the final Xen binary will be 24KB bigger when
> neither UBSAN nor GCOV.
>
> If this is not considered acceptable, then we could make the
> size of configurable in the Kconfig and decide it based on the
> features enabled.
>
> Changes in v2:
> - Fix typoes
> - Add Michal's reviewed-by tag
I cannot see one, so:
Reviewed-by: Michal Orzel <michal.orzel@xxxxxxx>
~Michal
|
