[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH V3.1] libxl: arm: Add grant_usage parameter for virtio devices



Hi,

On 30/06/2023 05:40, Viresh Kumar wrote:
On 13-06-23, 11:48, Anthony PERARD wrote:
On Tue, Jun 13, 2023 at 11:32:16AM +0530, Viresh Kumar wrote:
Currently, the grant mapping related device tree properties are added if
the backend domain is not Dom0. While Dom0 is privileged and can do
foreign mapping for the entire guest memory, it is still desired for
Dom0 to access guest's memory via grant mappings and hence map only what
is required.

This commit adds the "grant_usage" parameter for virtio devices, which
provides better control over the functionality.

Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
---
V3->V3.1:
- Print "0" or "1" in xenstore instead of "True" or "False" for grant_usage.

Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Hi,

I still don't see this patch pushed upstream. Are we waiting for some
release to happen ?

The patch is missing an ack from the golang maintainers. I noticed you didn't CC them (done now).

In the future, I would suggest to use one of the scripts in the repo to find the appropriate maintainers:
 * scripts/get_maintainers.pl: It will output the list of maintainers
 * scripts/add_maintainers.pl: It will add the maintainers for each
   patch files in a given directory.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.