[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/3] x86/boot: Clear XD_DISABLE from the early boot path
- To: Alejandro Vallejo <alejandro.vallejo@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 30 Jun 2023 13:28:39 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xAWpSxK2SAnaaX+uD85IMG2GwGydbob6sZgACDWSmlU=; b=jH6g4hJhuSBcoWooZDHXhT3KpFmEosn4BRqlvfsKZeUp45tXhFNX8+6Ls20aPrQFFXF60AzzGVGDsESGCz4TE5z6+ZQhvMw9iuwyR24VVJ914oam7oO64dIfebh4y5qbwjzDPOnYHLS3dEtDHW2nthVWUUelLEt0lktGUpMyHVN+yo3Hkt108QSihRN1PwoHLRkSVeUP7pkoV20/0PkSwoD6cYUD8QB8MJWCDDGGIawqudq+Ed3rBwA1I0Ds6dc0rsyQSvBqY8J7TfWTED6RLsM1uTPkZWVFgu8w6pRqgjvZmKL9JJv1I3F5EPNBZSSNiYZ5rTs3E/aejMwgXxzS5g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DaQjwvJEPd6RLNE7RDj5PGYrBxLN8ebFUZQ/FCxoh6KVrYukBcoOokeLVIzb5WXgMiV4MS6yMRKbHGfu+hz7wUDfjqr5BgEnsTJ9j5pLi3Qmu+D+vQIOrMZy6GJi7FfnBkAmob+UYKOJKP3yL1ybWmpLGX3ylDqm9UJWHdZXLLCfH3xKuGyJzLevcdEjJyF8gBiV1RYIF4eMBqy2T+InQfDkIFedcZ1N7VyQ49A9/YwlXJ/ap1Od5RX2MRmUqSrmt+eDR6DAWXovjB8fmTXM+85IOgQkBnD8fIOTS45IwsHhEiMYXDsyezw4B4vWtmKtaOdrgi4HHLoVjuwOcz2w3w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Fri, 30 Jun 2023 12:29:31 +0000
- Ironport-data: A9a23:y+qDKqqoduLnjLXhgL3rxwgZjJ9eBmI6ZBIvgKrLsJaIsI4StFCzt garIBnVMqmONDP9KoslbYS0p09V757SyddkSFc9qn8xEn9HpJuZCYyVIHmrMnLJJKUvbq7FA +Y2MYCccZ9uHhcwgj/3b9ANeFEljfngqoLUUbKCYWYpA1c/Ek/NsDo788YhmIlknNOlNA2Ev NL2sqX3NUSsnjV5KQr40YrawP9UlKq04GpwUmAWP6gR5weAzCFNVfrzGInqR5fGatgMdgKFb 76rIIGRpgvx4xorA9W5pbf3GmVirmn6ZFXmZtJ+AsBOszAazsAA+v9T2Mk0MC+7vw6hjdFpo OihgLTrIesf0g8gr8xGO/VQO3kW0aSrY9YrK1Dn2SCY5xWun3cBX5yCpaz5VGEV0r8fPI1Ay RAXAGwMRCujttjo+q34Y+RzwccILez3EYxK7xmMzRmBZRonabbqZvyToPV+jHI3jM0IGuvCb c0EbzYpdA7HfxBEJlYQDtQ5gfusgX78NTZfrTp5p4JuuzSVkFM3jeiraYSEEjCJbZw9ckKwj 2TK5WnmRDodM8SS02Gt+XOwnO7f2yj8Xer+EZXhr6Iy3ADDnTN75Bs+Swe1kN2fq2CERfl/d 3cmoTYSooUu6xn+JjX6d1jiyJKehTYVX9dSGus28gbL1KPQ5wubAUAPSjlcZJots8pebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakc5oRAt5tDipMQ5iELJR9M6Saqt1ISrSHf33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxodtzxooWp1 JTcp/Wj0Q==
- Ironport-hdrordr: A9a23:+erSI6HjApAQjm3cpLqE5seALOsnbusQ8zAXPiFKJSC9F/byqy nAppsmPHPP5gr5OktBpTnwAsi9qBrnnPYejLX5Vo3SPzUO1lHYSb1K3M/PxCDhBj271sM179 YFT0GmMqyTMWRH
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29/06/2023 1:17 pm, Alejandro Vallejo wrote:
> diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c
> index 168cd58f36..b2443b6831 100644
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -304,24 +304,20 @@ static void cf_check early_init_intel(struct
> cpuinfo_x86 *c)
> if (c->x86 == 15 && c->x86_cache_alignment == 64)
> c->x86_cache_alignment = 128;
>
> + if (bootsym(trampoline_misc_enable_off) &
> + MSR_IA32_MISC_ENABLE_XD_DISABLE)
> + printk(KERN_INFO
> + "re-enabled NX (Execute Disable) protection\n");
One other thing, which I'll also fix on commit.
This now prints per CPU on any system where we had to set XD_DISABLE.
It want's a c == &boot_cpu_data to limit it to once-only.
~Andrew
|
