[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH 0/5] Fix violations of MISRA C:2012 Rule 8.3 on parameter names


  • To: Federico Serafini <federico.serafini@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 30 Jun 2023 15:15:53 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jYZlIcGWZSSO/fOKj9E6L2yKtF0j7asYh+P7/uEn8k8=; b=Qqzd7sP/Zv+CuFw21cdVbCYe1bP5ToschA3fhWceH4LNTEMuj3m0v2c9scPT/t5wVkAzyZ73gjCE+f/0LZ1ha3d4wMnLKVCaf9CuzH7t5P673hWKDkYP+XluEDK0vX2v76UVTGvTetzjlAhvQQBjXTegqgkY7BMcgsJXli+H6GrGl7biLgq/ECl63sLhY+Dkugrr7SFniTrp5tlhCOOhnSFTL+maTw7Z9+Wpsin0CSVrTxioonfKt/3v8UulXxdOdivxrWWFOoMMcStf/pQyZVcvzkpJJHGRV0BT+L5bWcdjPibmYeQV2IaLG6rXv6HdYUHNaSiX/2gxv91edHD6dQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CCZ/oKtQ+fqTRU5BuJaLWsgr3umPD9fZqfIVfCCDr6u2WDwNYzvH3mOjForj8aQZM3p1hBFpU2GmhYTeZ53ZBPWZ8n0UQ523+aPti3KCcH81KPkq8JwqzhjJ2PSj5FY05xmZfuMYIzWH4ZZO7Ny1oY+kBC7tLw/mQseEHKNfG3ONwExuh6leVP6mygnAraaDVRrsXVzthENgjlPz3T74tNFryB/dZnKMhLSIsNbBPMRCE6GiOIbha9BxryYDCcEK35Rbx9fIWJWmpsm7pbSzGigtLDBPJR/Fa/E/HRRzjcWP/5TaUUfdw4mbp2IKzUbvZ1MNkEmiZXntbgPT+GcDEA==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: consulting@xxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <xenia.ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>
  • Delivery-date: Fri, 30 Jun 2023 14:16:21 +0000
  • Ironport-data: A9a23:IK2h86tuAxdYKpwuYFFlg88w0ufnVJReMUV32f8akzHdYApBsoF/q tZmKWzVafeLZWfxLo0kOo22/EIF75HSzNQwTws9ri9hQSxB+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg3HVQ+IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4rKq4Vv0gnRkPaoQ5AGFzyFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwBRABbEmyuriKwYmmV8lqo859JvWwFdZK0p1g5Wmx4fcOZ7nmGv+PwOACmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0ovjv6xbrI5efTTLSlRtm+eq njL4CLSBRYCOcbE4TGE7mitlqnEmiaTtIc6TeTkqaEz3QHProAVIEMqb2KihN2Bs1T9dfwCL kUyyC1tirdnoSRHSfG4BXVUukWssBMQVsBRGOp88wyXw6TV5QexDHULVTNHZ5ots8pebSwn0 BqFks3kARRrsaaJUjSN+7GMtzSwNCMJa2gYakcsRgwD+MTnvIA1gTrFU9l4Hai6yNbyHFnYw TqHsSw/jLU7ltMQ2uOw+lWvqy2ojojESEgy/Aq/dnqs8wdRdIOjIYuy5jDz8f9FJZ2xUlqFs X4LisWaqusJCPmlnS2WSeQJFZmj5uqJPTPRh1JiBd8q8DHF02a7fJpb6TV3LlpBOMcYdTLnb UnftBkX75hWVFOocKkxZYuyAsYryKHIFNL5W/SSZd1LCrByeRGG+mdyZEeW92HrjEUo16o4P P+zat2wBHwXDaBmyjueROoH17IvgCckygv7QJHwzx2jl72EdnORYb4APB2FaeVRxLOJpgTct cxWOMqDxxxcV/DWayzbt4UUKDgiJGkyA9b1tslebKiDKw5qFXsJAvrdh7gmfuRYc799k+7J+ jS4RRVewV+m33nfc13WNDZkda/lWot5oTQjJyswMF202n8lJ4Gy8KMYcJhxdr4inAB+8cNJo zA+U53oKpxypv7volzxsbGVQFReSSmW
  • Ironport-hdrordr: A9a23:K2C0gKhru+FoJ0wEhzXatnfwTHBQXtgji2hC6mlwRA09TyX4ra CTdZsguyMc5Ax8ZJhCo7G90cu7MBHhHPdOiOF7V9qftWHdyQ+VxepZnO7fKlPbdBHWx6px74 BLda9iBMzsZGIK7voTq2GDYrEd/OU=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 29/06/2023 4:55 pm, Federico Serafini wrote:
> Federico Serafini (5):
>   x86: swap parameter names of hvm_copy_context_and_params() declaration
>   x86: change parameter names of nestedhvm_vcpu_iomap_get() definition
>   x86/vlapic: change parameter names in function definitions

I've acked/committed the first 3 patches, with the various tweaks that
Stefano identified.

nestedhvm_vcpu_iomap_get() is utter nonsense (it would absolutely not
have passed review if I'd seen it before it went in), but untangling
nested virt is multiple cans of worms, so I've put the name changes in
as-are to avoid blocking the MISRA effort.

The final two patches need a bit more consideration time.

~Andrew



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.