[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 10/10] x86 setup: refactor efi, pvh and multiboot entrypoints to new boot info
- To: Christopher Clark <christopher.w.clark@xxxxxxxxx>
- From: Michael Young <m.a.young@xxxxxxxxxxxx>
- Date: Mon, 3 Jul 2023 22:35:04 +0100 (BST)
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=durham.ac.uk; dmarc=pass action=none header.from=durham.ac.uk; dkim=pass header.d=durham.ac.uk; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ErmgjoGgjac2N22Sjh2+rFJmPgFzQoO2T9EDJXceqgY=; b=Eb4wTEasYBjQR+MfWmrThUqV5/l96Pgp+nRVxgzO+ZkXsf0tN+WeENo+kzCewr7h9TnuYOAhAEfNl6yQNr06O3Lz1BHmdcAHXADTNcu6MAfU+dugXlEP+kIl5IRaC5pG6+BiMnoAV3Yw4UMToidQgE+TIfkr3FP8GWEjmHlhQFVBub1GLucacaPLkkkdyzEalx8CK4DyJi4DDu31BJPwQouB/9fRsZ4ytSZLaiDFeRDSqjdRa5qEx8mi5xRJ8CSI+/I8zBnjsSoojYkABVgsB1FuTsKrcC3RWeguEXPmW3jRNHtoNJq4ge3MM6R9La/UpDWjO9hX2CKuFwUpc8DayA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XQnY/7lZAsxwxYwJD0CNwOIdatVrHBaNJyNTQfXOxXvOBOnHEGnPrkQjcdMiH7mMkBuknubkqkJQux2qfp27yMmKGxYWqSEfJvzjTW/r6XkeZ91mKkQHlUNnTsosB0kqQXIOWA+DdJVtPaw+PDTiKV/7whlO4EFe7rnlIrP0NfevM5DgIzulmSHKiKSEtxRamcN9TkNE/nerDbmVX/JKza4RIVsSbhH2F0mfjcH7QwxILZMwEWuSCat8W1SSzSKKKDCZK09h87iesU5eCyZBTaj2AEhEUcac5HoqkUQt5hlWQXVOh4Kh7GDW/eUsf0UI4UdvsBBlLw783TjhqhM6MQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=durham.ac.uk;
- Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Daniel Smith <dpsmith@xxxxxxxxxxxxxxxxxxxx>, stefano.stabellini@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Luca Fancellu <luca.fancellu@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Rich Persaud <persaur@xxxxxxxxx>
- Delivery-date: Mon, 03 Jul 2023 21:35:18 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
I was trying a test build with these patches and got the following error
In function 'mbi2_reloc',
inlined from 'reloc' at arch/x86/boot/reloc.c:437:16:
arch/x86/boot/reloc.c:349:20: error: 'bi_mods' may be used uninitialized
[-Werror=maybe-uninitialized]
349 | bi_mods[mod_idx].start = get_mb2_data(tag, module,
mod_start);
| ^
arch/x86/boot/reloc.c: In function 'reloc':
arch/x86/boot/reloc.c:237:25: note: 'bi_mods' was declared here
237 | struct boot_module *bi_mods;
| ^~~~~~~
In file included from arch/x86/boot/reloc.c:29:
In function 'mbi2_reloc',
inlined from 'reloc' at arch/x86/boot/reloc.c:437:16:
arch/x86/boot/reloc.c:365:43: error: 'arch_bi_mods' may be used
uninitialized [-Werror=maybe-uninitialized]
365 | bi_mods[mod_idx].arch = _addr(&arch_bi_mods[mod_idx]);
arch/x86/boot/defs.h:47:46: note: in definition of macro '_addr'
47 | #define _addr(val) ((unsigned long)(void *)(val))
| ^~~
arch/x86/boot/reloc.c: In function 'reloc':
arch/x86/boot/reloc.c:238:29: note: 'arch_bi_mods' was declared here
238 | struct arch_bootmodule *arch_bi_mods;
| ^~~~~~~~~~~~
cc1: all warnings being treated as errors
Is there a problem in the code?
Michael Young
|
