[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] tools: Fix ifdef for aarch64 that should include also arm


  • To: Luca Fancellu <luca.fancellu@xxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 4 Jul 2023 10:42:01 +0100
  • Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, <bertrand.marquis@xxxxxxx>, <wei.chen@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Delivery-date: Tue, 04 Jul 2023 09:42:23 +0000
  • Ironport-data: A9a23:WC4F664FWwvwp4jd8NsNQQxRtN7HchMFZxGqfqrLsTDasY5as4F+v jcfWz/Xbq6MZWL2ftxzPdng/B8C6MXdyNVqSQU9ris8Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9lU35ZwehBtC5gZlPa8T4AeE/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m7 bsWDCkVNgC/vuPpwKqQZuZpt5UiFZy+VG8fkikIITDxCP8nRdbIQrnQ5M8e1zA17ixMNa+AP YxDM2MpNUmeJUQVYT/7C7pn9AusrnD5bz1frkPTvact6nLf5AdwzKLsIJzefdniqcB9xx/D9 jqXoTmjav0cHOShlwie9Sz8v9/ewgTlVoQ8Poyy3dc/1TV/wURMUUZLBDNXu8KRjlO1UpRRI kof9y4qsIA77kntRd74NzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnMU7XyAw3 1mF2dbgHyVysaa9QGiYsLyTqFuaJiUUa2QCaCksRBEApdLkpekbkRbnXttlVqmvgbXdHDjqx jmQoSsWhrMNjNUK3aG24VDGhT23opHDCAUy423/V3qo9ApjaKa5Zoaj7h7Q6vMoEWqCZgDf5 j5ewZHYtb1QS8jXz0RhXdnhApmxoPihKSWEkWJWHsYh7x+B9HuSLIFptWQWyFhSDioURdP4S BaN6VMNusYObSvCgbxfONzoVZlzpUT0PZG8D62PMIITCnRkXFXflByCc3J8yIwEfKIEtagkc amWfs+3ZZrxIfQ2lWHmLwvxPFJC+8zf+Y8wbcqhp/hf+eDCDEN5sJ9cWLd0Usg37bmfvCLe+ MtFOs2Bxn13CbOuMnWPoNRKcwxWfBDX4KwaTOQOJ4a+zvdOQjl9W5c9P5t8E2Cao0ilvriRp SzsMqOp4FH+mWfGOW23hoNLMdvSsWJEhStjZ0QEZA/4s0XPlK7ztM/zgbNrJ+h4nAGipNYoJ 8Q4lzKoWasfEmieo2tBNvEQbuVKLXyWuO5HBAL9CBBXQnKqb1ahFgPMFuc3yBQzMw==
  • Ironport-hdrordr: A9a23:aLdbkaxhqF2IroRHEj12KrPwFr1zdoMgy1knxilNoEpuA6ulfq eV7ZcmPH7P6Ar5N0tKpTntAsO9qBDnlKKdg7N/AV74ZniDhILAFugL0WKF+VDd8kbFmNK1u5 0NT0DQYueAa2STIazBkWuF+3dL+qjjzJyV
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Jun 08, 2023 at 02:59:12PM +0100, Luca Fancellu wrote:
> Commit 56a7aaa16bfe introduced some SVE related code that is protected by
> '#if defined(__aarch64__)', the issue is that this doesn't take into
> consideration when the toolstack is compiled for an arm32 Dom0 running on
> an arm64 platform, it should be able to create SVE enabled guests but with
> the current code it's not.
> 
> So fix the issue by compiling the code when the toolstack is compiled for
> both arm32 and arm64.
> 
> Fixes: 56a7aaa16bfe ("tools: add physinfo arch_capabilities handling for Arm")
> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>

Thanks,

-- 
Anthony PERARD



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.