[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 06/52] xen/arm: introduce CONFIG_HAS_MMU


  • To: Penny Zheng <Penny.Zheng@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Ayan Kumar Halder <ayankuma@xxxxxxx>
  • Date: Tue, 4 Jul 2023 12:14:58 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fAI8Ye1hiMiM5bokZODWSS1ZmLb9C8JWqzXtgxkAowk=; b=Xm39IlFVxPayxiCV9mYhnT9w3PQOc8Z4Th3seoBs5GMsMNlfmF8E5GTaDadjqY8Rx1WIvMNIIIJ3HmDlwkWZ0HE2n6nlGlFIrbjNwUoDqAGQpjS+eYs2h+jvQioNkwLqma8aq75hPtWCGQKAWovKOcpkdsOQ0JBF8wP9D+xxs78HG00VeBos+qSPyz/llkOjqJTLZqTIFTJwGAa/V+wmqmY41VrBk41DGbQ/xX4FK0lTHciMkYAZyNG6eJEEBpi95zijSB0qBamVuTgv6M2yGqXAW7FHiae7/oTgiflg4cllgOEL5ePQL6lbEQG0Yo997Pr0Q8kL04RQ5kIzi2lshQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b1qjbqt1h5BVOF9bs5EaQ0vT3FIa5ekaPZkAmJ+UDByOb0SkDjIGNXMGMx5HrMGEBjXPFeaxH0s32qhOoxAMBkq3Y4CaJcJjy6SQvQkF1c5PIwe3fozP21Xo+VVd29J4r4ONJs1h/mhPm90BKTaTKDwcKESAYelA1SvkoXUZ+xFjhhA6WpYztsHzLSUvbmjoBeRfDysNCMoSmYS4xSwXSYWo120R1l6/80lbfjfvTmtE0C7L9BxduOY5CFL6TqTNM37ROguqAtpZTkJydblzL7qR76QB76q04i6zTsCkzDjgIpdLtCqZQAcv6m+hVFTkqcXcvOQg/o8AscK6b2sPyQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;
  • Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Wei Chen <wei.chen@xxxxxxx>
  • Delivery-date: Tue, 04 Jul 2023 11:15:26 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Hi Penny,

On 26/06/2023 04:33, Penny Zheng wrote:
CAUTION: This message has originated from an External Source. Please use proper 
judgment and caution when opening attachments, clicking links, or responding to 
this email.


This commit wants to introduce a new Kconfig CONFIG_HAS_MMU to guard
MMU-related codes, to tell two different memory management architecture:
VMAS and PMSA.

In a VMSA system, a Memory Management Unit (MMU) provides fine-grained
control of a memory system through a set of virtual to physical address
mappings and associated memory properties held in memory-mapped tables
known as translation tables.

Signed-off-by: Penny Zheng <penny.zheng@xxxxxxx>
Signed-off-by: Wei Chen <wei.chen@xxxxxxx>
---
v3:
- new patch
---
  xen/arch/arm/Kconfig | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
index ff17345cdb..fb77392b82 100644
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -60,6 +60,14 @@ config PADDR_BITS

  source "arch/Kconfig"

+config HAS_MMU
+       bool "Memory Management Unit support in a VMSA system"
+       default y
+       help
+         In a VMSA system, a Memory Management Unit (MMU) provides 
fine-grained control of
+         a memory system through a set of virtual to physical address mappings 
and associated memory
+         properties held in memory-mapped tables known as translation tables.
+
  config ACPI
         bool "ACPI (Advanced Configuration and Power Interface) Support 
(UNSUPPORTED)" if UNSUPPORTED
         depends on ARM_64

I don't think you need this option.

In patch 52 ("xen/arm: add Kconfig option CONFIG_HAS_MPU to enable MPU system support"), you have introduced "HAS_MPU" option.

May be you can introduce "HAS_MPU" option a bit earlier, so that "!HAS_MPU" is "HAS_MMU". So, you will not need this new option.

Let me know if this makes sense.

- Ayan

--
2.25.1





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.