Re: [PATCH] xen/arm: vgic: Add missing 'U' in VGIC_ICFG_MASK for shifted constant

[Julien Grall <julien@xxxxxxx>]

Hi,

On 30/06/2023 00:03, Stefano Stabellini wrote:
> On Fri, 30 Jun 2023, Henry Wang wrote:
> > With UBSAN on some arm64 platforms, e.g. FVP_Base_RevC-2xAEMvA, the
> > following splat will be printed while Dom0 is booting:
> > ```
> > (XEN) ==================================================================
> > (XEN) UBSAN: Undefined behaviour in arch/arm/vgic.c:372:15
> > (XEN) left shift of 1 by 31 places cannot be represented in type 'int'
> > (XEN) Xen WARN at common/ubsan/ubsan.c:172
> > (XEN) ----[ Xen-4.18-unstable  arm64  debug=y ubsan=y  Not tainted ]----
> > ```
> >
> > This is because there is a device node in the device tree with 0xf
> > as the interrupts property. Example of the device tree node is shown
> > below:
> > ```
> > ethernet@202000000 {
> >      compatible = "smsc,lan91c111";
> >      reg = <0x2 0x2000000 0x10000>;
> >      interrupts = <0xf>;
> > };
> > ```
> > and this value is passed to vgic_get_virq_type() as "index" then "intr"
> > in VGIC_ICFG_MASK.
> >
> > Add the missing 'U' in VGIC_ICFG_MASK as a fix, and this should also
> > addressing MISRA Rule 7.2:
> >
> >      A "u" or "U" suffix shall be applied to all integer constants that
> >      are represented in an unsigned type
> >
> > Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
It is now committed.

Cheers,

--
Julien Grall