Re: [PATCH v3 08/52] xen/arm64: move MMU related code from head.S to mmu/head.S

[Julien Grall <julien@xxxxxxx>]

On 05/07/2023 05:49, Penny Zheng wrote:
> Hi Julien
Hi,

> On 2023/7/5 05:46, Julien Grall wrote:
> > Hi Penny,
> >
> > On 26/06/2023 04:33, Penny Zheng wrote:
> > > From: Wei Chen <wei.chen@xxxxxxx>
> > >
> > > There are lots of MMU specific code in head.S. This code will not
> > > be used in MPU systems. If we use #ifdef to gate them, the code
> > > will become messy and hard to maintain. So we move MMU related
> > > code to mmu/head.S, and keep common code still in head.S. We also
> > > add .text.idmap in mmu/head.S to make all code in this new file
> > > are still in identity map page but will be linked after head.S.
> > >
> > > As "fail" in head.S is very simple and this name is too easy to
> > > be conflicted, so duplicate it in mmu/head.S instead of exporting
> > > it.
> > >
> > > And some assembly macros that will be shared by MMU and MPU later,
> > > we move them to macros.h.
> > Aren't those macros already shared between head.S and mmu/head.S?
> Correct me if I understand wrongly, so you want to remove the mention of 
> MPU, and rephrase it to
So far, I am asking whether all the macros moved in macros.h are shared 
between mmu/head.S and head.S. If they are then...
> "
> As some assembly macros need to be shared by head.S and mmu/head.S,
> we will move them to macros.h.
> "
... yes this is the rephrase I would like to see.

Cheers,

--
Julien Grall