[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] xen/arm: Kconfig: ACPI should depend on UEFI





On 05/07/2023 13:30, Julien Grall wrote:
Hi Jan,

On 05/07/2023 13:04, Jan Beulich wrote:
On 05.07.2023 13:55, Julien Grall wrote:
--- a/xen/arch/arm/Kconfig
+++ b/xen/arch/arm/Kconfig
@@ -63,11 +63,11 @@ source "arch/Kconfig"
  config ACPI
      bool "ACPI (Advanced Configuration and Power Interface) Support (UNSUPPORTED)" if UNSUPPORTED
-    depends on ARM_64
+    depends on ARM_64 && ARM_EFI

Wouldn't it make sense to drop the ARM_64 dependency then? It's now
redundant, and it seems quite likely that if EFI was ever support
for 32-bit, ACPI could then be supported there as well.

I think so. I am not planning to resend a new version for that. So I will do it on commit and mention it in the commit message.

Actually no. It would be easier to add UEFI on Arm32 compare to adding ACPI. So it would be best to keep ARM_64 here at least for the time been.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.