[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/arm: Kconfig: ACPI should depend on UEFI
- To: Julien Grall <julien@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 5 Jul 2023 12:51:03 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ub/C/RLbS6rI+dxyw0fnlJ0n+0f8QBhZXs+h7BtJJuw=; b=W/G9znqQWbjUSmXK/eWMMLYQ5iswbdAO+3t+CsVeiN8XhsPy/nvNp7WBIyf7qWmLPJ7EuBSXeT4SeZHeOPNEkcXhRwI0GwSyMsZQcZMIZ+Z696NkeTCiDykuJm7uJE95Fn6B99O/SIVmk/tGEFTuxh1wUk9pvPsMZRATVGX7gjjHIWDfroTtP05zqzbrBb1LxXTrukMEFXeLdUnplAxPmHBg1kCUFUAVPGRECFeol2la6tyINAeMp9SzsWi+GPrJFLhDjOQYcrg04HmriENPHAfNS77j5G55Be2j+V/WPlKDLCTEAxnDqpcDSgE9oS6wPmIMjk8Ze2ru1P1awDWQig==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eCoslujw56y/OSov1rHkDriXWhtOWQ6UFfrSlflNWJAv3VJF1Tt3CSGz7bApqjQkcp6bcJyWViA5i/3X2pQdk0dmGXIfUJYSsWmlyWzSemQlBkPxtRpNYDU8vNwQ7ybYqWl9ESElTX2UpFpYzwFQfkyWBs7GzjkuswXjWKxxGyM5ReFNHTA2paKRZyfukTl0DbcIGJYjhP1r3H5IU8atPRUrRgHTXciPNKamBhvPrpmsIRI08x32HhSveITb2d7EtVNZBPiV8oQVnFg5SOz6OulsGyjVrNnzzOz5kZstGBHwlPAkvOj88D1SpU8OkoIGKiGqI+bV2n/QDeEaz2/a5w==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, Penny Zheng <Penny.Zheng@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Julien Grall <jgrall@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>
- Delivery-date: Wed, 05 Jul 2023 12:51:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZrzemFhjMGQXcTkKAEu+0mA/HSq+rIDqA
- Thread-topic: [PATCH] xen/arm: Kconfig: ACPI should depend on UEFI
Hi Julien,
> On 5 Jul 2023, at 13:55, Julien Grall <julien@xxxxxxx> wrote:
>
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> On Arm, it is not possible to use ACPI without UEFI. In fact disabling
> UEFI but not ACPI will lead to a compilation error:
>
> ld: prelink.o: in function `acpi_os_get_root_pointer':
> /builds/xen-project/people/andyhhp/xen/xen/drivers/acpi/osl.c:73:
> undefined reference to `efi'
> /builds/xen-project/people/andyhhp/xen/xen/drivers/acpi/osl.c:73:(.init.text+0x8ac0):
> relocation truncated to fit: R_AARCH64_ADR_PREL_PG_HI21 against
> undefined symbol `efi'
>
> So make the dependency clear in the Kconfig.
>
> This was spotted by the randconfig build in gitlab CI.
>
> Fixes: 12314be5749e ("xen/arm: make ARM_EFI selectable for Arm64")
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Reviewed-by: Bertrand Marquis <bertrand.marquis@xxxxxxx>
Cheers
Bertrand
> ---
> xen/arch/arm/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig
> index c30f32457388..439cc94f3344 100644
> --- a/xen/arch/arm/Kconfig
> +++ b/xen/arch/arm/Kconfig
> @@ -63,11 +63,11 @@ source "arch/Kconfig"
>
> config ACPI
> bool "ACPI (Advanced Configuration and Power Interface) Support
> (UNSUPPORTED)" if UNSUPPORTED
> - depends on ARM_64
> + depends on ARM_64 && ARM_EFI
> ---help---
>
> Advanced Configuration and Power Interface (ACPI) support for Xen is
> - an alternative to device tree on ARM64.
> + an alternative to device tree on ARM64. This requires UEFI.
>
> config ARM_EFI
> bool "UEFI boot service support"
> --
> 2.40.1
>
|
