[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 2/6] xen/riscv: introduce reset_stack() function
- To: Oleksii Kurochko <oleksii.kurochko@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 6 Jul 2023 13:17:23 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z4dy5ESI3AgHnzlzCu9+1b+Pp2FyvKSQvyxwkQkZn/I=; b=VD28/lGBkoUQv2mDc0+pGW7KckdkqXa+eUEtDWVmdvIkostK6pUBAyAsisbFWMNE3udFKxoVuxU3sjA4Ccd/kdiFvFLda2tFTzoMP5D60h8tMJp5pp/USQnuaAOeXaQqLlEYfM3Tvk7HSwi1iTJKMK0ttrTaQ3UkKKypOkHFqxo1t0eXZ5ek5QIR8JMbl5NyL/RTHKNJyZeEtXFRX2JTQ2vKNusYjVoRHYn0ixgsI9j7LDamnrgVqPnRi7DqLAq1oV4ew8Z3wF3WGSnS6PxHOwAGtCserrtmEwLzsr8YGngG70tZoGbBbJu0CnIBZlmmcqQkBuEyX4WlUBF5oGQ45Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BQDM0a4Ra7eV6OuWXpFajAiPuolR9yrTAZLJ7zT2qiHx4cHm2xiVUi/TiW1OG3x9dKUtjF1NMjaTS/U1wlnL+eFJrh8FDH1rkuIhdxie7WSM+E7C0oPTxolHuPWkQBeSFwuC2hjFF+mNWIwHv/bMKhc5GhH00I4+5bDt6tZiJB+iBv23tiEI5VuadRMnzPh51iaplC9Ca5/ztagxZZaK5SFhtyCkBHMWecEmyp77POpLybNPP0hpMZzRBVQd4KFYJjyTO0EycW0Ux4KSXshTpKkIakXtdAKpYLh1FBOC1Mwf/NNsl9smHZKB4pn0GdW72Ph0fYW37mCbmltJ3NqbCA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 06 Jul 2023 11:17:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.06.2023 15:34, Oleksii Kurochko wrote:
> --- a/xen/arch/riscv/riscv64/head.S
> +++ b/xen/arch/riscv/riscv64/head.S
> @@ -27,8 +27,16 @@ ENTRY(start)
> add t3, t3, __SIZEOF_POINTER__
> bltu t3, t4, .L_clear_bss
>
> + jal reset_stack
> +
> + tail start_xen
> +
> + .section .text, "ax", %progbits
> +
> +ENTRY(reset_stack)
> la sp, cpu0_boot_stack
> li t0, STACK_SIZE
> add sp, sp, t0
>
> - tail start_xen
> + ret
> +
Looking at patch 4 you will want to add a comment here to emphasize
that a0 and a1 have to remain unclobbered.
Jan
|
