Xen project Mailing List

Re: [PATCH v1 1/2] xen/arm: pci: introduce PCI_PASSTHROUGH Kconfig option

To: Julien Grall <julien@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>

From: Stewart Hildebrand <stewart.hildebrand@xxxxxxx>

Date: Thu, 6 Jul 2023 21:41:45 -0400

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=xen.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eRVFESTWrB4pDmbWOURdcCtibQWmV9LAbZT42t5XQZ0=; b=gp4qy8eKzHzjSV4SFuiTDaqneb2M/etdcGXnBDYFkiCdOGVnwzCd72oLwilpY85ZlNuvRzEL3+iZl5u74i9VDUphv5KzQRtObf+9dgOKIx2pBg262TaoUMSUrdX8jjX7D4l9rygcjAJUbCogoHkgT96/3VzV1tM8IjuNTCpZsmquBrhBGt3aAIHzEYZ6wX/x+L41ZlGftoj2HpZDjJ1FOOHKxtUpmVRFErDxr9j1YPjT31IUyKVBTy1UNaac0+DfIo3rIVGYJJPM2yoV68BBAxR6+WpJrZ5cft/441/CAs7xVf5XL3svPwwLlXfyUEFiR64UGbX+uNtRRvpVjvZKmQ==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HP937TCENkxaD7CXTedAu74VM0GzWObrFJWFkNesG+t0SiivCRRZ2zeVbycDIHZc7cTKoiobKjfqSFVf/lSBTuulQFTcYSzbgZQGPhhOJ3d6qiBGXlmCoXwjF/UisykbyvgmCZ+22QpxMPRHlYwgTIEZ1LutiTCkIQv2Gk72uU+xPd2hwbEIK7Y1OU0yRVIwEaMV7872wwhzzd0ZB8SDXxrY1Thuw0089yPIhz5fVNp5zlEGFMIkyQ5N9dO7tKkxhXaV1uJjJnq871Sk9yrqDpWjrWwMhQY73aHgGtf31GMcfI1/dqMaJwh35LqRcmWEUpIyY8VWIj0GZh4gILwgsA==

Cc: Rahul Singh <rahul.singh@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksandr Tyshchenko <oleksandr_tyshchenko@xxxxxxxx>, Artem Mygaiev <artem_mygaiev@xxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxx>

Delivery-date: Fri, 07 Jul 2023 01:42:01 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 6/25/23 08:51, Julien Grall wrote: > Hi, > > On 20/06/2023 16:29, Stewart Hildebrand wrote: >> From: Rahul Singh <rahul.singh@xxxxxxx> >> >> Setting CONFIG_PCI_PASSTHROUGH=y will enable PCI passthrough on ARM, even >> though >> the feature is not yet complete in the current upstream codebase. The >> purpose of >> this is to make it easier to enable the necessary configs (HAS_PCI, >> HAS_VPCI) for >> testing and development of PCI passthrough on ARM. >> >> Since PCI passthrough on ARM is still work in progress at this time, make it >> depend on UNSUPPORTED. >> >> Signed-off-by: Rahul Singh <rahul.singh@xxxxxxx> >> Signed-off-by: Stewart Hildebrand <stewart.hildebrand@xxxxxxx> >> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxx> >> --- >> (cherry picked from commit 9a08f1f7ce28ec619640ba9ce11018bf443e9a0e from the >> downstream branch [1]) >> >> Changes from downstream to v1: >> * depends on ARM_64 (Stefano) >> * Don't select HAS_VPCI_GUEST_SUPPORT since this config option is not >> currently >> used in the upstream codebase. This will want to be re-added here once the >> vpci series [2] is merged. >> * Don't select ARM_SMMU_V3 since this option can already be selected >> independently. While PCI passthrough on ARM depends on an SMMU, it does >> not >> depend on a particular version or variant of an SMMU. >> * Don't select HAS_ITS since this option can already be selected >> independently. >> HAS_ITS may want to be added here once the MSI series [1] is merged. >> * Don't select LATE_HWDOM since this option is unrelated to PCI passthrough. >> >> [1] >> https://gitlab.com/xen-project/people/bmarquis/xen-arm-poc/-/commits/poc/pci-passthrough >> [2] >> https://lists.xenproject.org/archives/html/xen-devel/2023-06/msg00863.html >> --- >> xen/arch/arm/Kconfig | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/xen/arch/arm/Kconfig b/xen/arch/arm/Kconfig >> index 61e581b8c2b0..3d22cd26a68c 100644 >> --- a/xen/arch/arm/Kconfig >> +++ b/xen/arch/arm/Kconfig >> @@ -184,6 +184,15 @@ config STATIC_SHM >> help >> This option enables statically shared memory on a dom0less system. >> >> +config PCI_PASSTHROUGH >> + bool "PCI passthrough on ARM (UNSUPPORTED)" if UNSUPPORTED > > The series is already under an Arm category. So I would drop "ARM" here. OK > NIT: Also, I think it should be EXPERT rather than UNSUPPORTED. I view > the former as in more "experimental" than the latter. OK >> + depends on ARM_64 >> + select HAS_PCI >> + select HAS_VPCI >> + default n >> + help >> + PCI device passthrough on ARM (UNSUPPORTED) > > Same. OK

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.