[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/32] block: Provide blkdev_get_handle_* functions
- To: Jan Kara <jack@xxxxxxx>
- From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
- Date: Fri, 7 Jul 2023 04:28:41 -0700
- Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-block@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, Jens Axboe <axboe@xxxxxxxxx>, Alasdair Kergon <agk@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Anna Schumaker <anna@xxxxxxxxxx>, Chao Yu <chao@xxxxxxxxxx>, Christian Borntraeger <borntraeger@xxxxxxxxxxxxx>, "Darrick J. Wong" <djwong@xxxxxxxxxx>, Dave Kleikamp <shaggy@xxxxxxxxxx>, David Sterba <dsterba@xxxxxxxx>, dm-devel@xxxxxxxxxx, drbd-dev@xxxxxxxxxxxxxxxx, Gao Xiang <xiang@xxxxxxxxxx>, Jack Wang <jinpu.wang@xxxxxxxxx>, Jaegeuk Kim <jaegeuk@xxxxxxxxxx>, jfs-discussion@xxxxxxxxxxxxxxxxxxxxx, Joern Engel <joern@xxxxxxxxxxxxxxx>, Joseph Qi <joseph.qi@xxxxxxxxxxxxxxxxx>, Kent Overstreet <kent.overstreet@xxxxxxxxx>, linux-bcache@xxxxxxxxxxxxxxx, linux-btrfs@xxxxxxxxxxxxxxx, linux-erofs@xxxxxxxxxxxxxxxx, linux-ext4@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-mm@xxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-nfs@xxxxxxxxxxxxxxx, linux-nilfs@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-pm@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, linux-s390@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, "Md. Haris Iqbal" <haris.iqbal@xxxxxxxxx>, Mike Snitzer <snitzer@xxxxxxxxxx>, Minchan Kim <minchan@xxxxxxxxxx>, ocfs2-devel@xxxxxxxxxxxxxx, reiserfs-devel@xxxxxxxxxxxxxxx, Sergey Senozhatsky <senozhatsky@xxxxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Sven Schnelle <svens@xxxxxxxxxxxxx>, target-devel@xxxxxxxxxxxxxxx, Ted Tso <tytso@xxxxxxx>, Trond Myklebust <trond.myklebust@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 07 Jul 2023 11:29:39 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Jul 06, 2023 at 06:14:33PM +0200, Jan Kara wrote:
> > struct bdev_handle *bdev_open_by_path(dev_t dev, blk_mode_t mode,
> > void *holder, const struct blk_holder_ops *hops);
> > void bdev_release(struct bdev_handle *handle);
>
> I'd maybe use bdev_close() instead of bdev_release() but otherwise I like
> the new naming.
We're using release everywhese else, but if Jens is fine with that I
can live with close.
|
