[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 0/2] Add escape character argument to Xen console
- To: Peter Hoyes <Peter.Hoyes@xxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Wed, 12 Jul 2023 08:26:32 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/fdltWaRaZ3Qd0pr9Pl71uUsm0vggxSmJCiXLHjsZOE=; b=CPdcICXt7aAKQ3+01FbFUVVVjAZcPA0w9w+Ojwxz7zPx9YAgDTgCU7A98GlNIfvJsUARIIm/af00mttcnt61ozyXHPqzhkXZ44zmZ59yA9vA3Lrfk9lqMpaV3HnlhXJEUDDMlt7HgXcRBAfnzaoosVUlIHWlLclt0pJvIuCuHEcJLFJRDZtuPd9k11ghE/SoYj40UhlbFzVeIaOF3kSEg/wEqdeaGbreqJcyuFWK2ik0bwFy4PLv9Gw0mz9jqhPpQcw917n8T1DpS4PngtFUijDudJBDNw+l5u6lw9FtqY3DIk22rIHw1On6uSciaeeUkANWpiFcRJpi8W/r5U1bow==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=imr9aj5WcY+HdeDTt0vfkcz15RKo6/87Pmy+K5aJltwOU6XZuGJ8u1newIq/e82HFvXbXKNGMx4ODBi6wJAC08BqETJoQowOaAJG/7mwB9VnTC5ir+mvkkVoru8cfBqfYKNLSti5OeiZh/YTKVEU4bLxpYiof9N3TaxtWGbRsieFP4kMjYmuKHc3+7KC3EUsH7QLJcF2jg8PtmbBeTNE9dP7K2NDDcin1M3xdcuHIr2nfJrZmevwbSc/3TyZBxxUkwcKgs1gT28boqsv1sM2/mlkEph3RSSgktcBT52kKVWZMHK99h7AWWLjaJbda3NAE/+VC/EwRvHMJ18Fr/JAOw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Luca Fancellu <Luca.Fancellu@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 12 Jul 2023 08:26:53 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZtJOZfmsm6IPK4UC9HWuyh33zD6+1y+0A
- Thread-topic: [PATCH v4 0/2] Add escape character argument to Xen console
Hi Peter,
> On 12 Jul 2023, at 09:35, Peter Hoyes <Peter.Hoyes@xxxxxxx> wrote:
>
> From: Peter Hoyes <Peter.Hoyes@xxxxxxx>
>
> Dom0 may be accessed via telnet, meaning the default escape character
> (which is the same as telnet's) cannot be directly used to exit the
> console. It would be helpful to make the escape character customizable
> in such use cases, falling back to the existing
>
> Make the necessary changes to the console client, libxl and the xl
> console sub-command to support this.
>
> Changes in v4:
> * Update xl docs
> * Add necessary changes for libxl API version compatibility
> * Improve escape sequence argument validation
>
> Peter Hoyes (2):
> tools/console: Add escape argument to configure escape character
> xl: Add escape character argument to xl console
In the patches you did not add a change log to get what has been modified
between versions of the serie.
This is making it a bit harder to diff review.
Could you resent your serie and add a change log:
--
Changes in v4:
- xxx
- xxx
Changes in v3:
- xxx
...etc
Thanks
Cheers
Bertrand
>
> docs/man/xl.1.pod.in | 8 ++++++-
> tools/console/client/main.c | 21 +++++++++++++----
> tools/include/libxl.h | 39 +++++++++++++++++++++++++++++---
> tools/libs/light/libxl_console.c | 30 +++++++++++++++++-------
> tools/xl/xl_cmdtable.c | 3 ++-
> tools/xl/xl_console.c | 10 +++++---
> tools/xl/xl_vmcontrol.c | 2 +-
> 7 files changed, 92 insertions(+), 21 deletions(-)
>
> --
> 2.34.1
>
|
