[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v3 07/15] x86/vmx: fix violations of MISRA C:2012 Rule 7.2
- To: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 12 Jul 2023 12:52:21 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KpZYUK4NCM8LATODje/gfsOtb3Cjjx/3p1PoPTJQIxg=; b=Izsy33YGkjc2W3Ttru0+DjrLVeq7v11AmEP0uqANuvPQZYasao/DBQhpsU55TjI8I2y/D0rTAUbEwCTazZLzR9f5esPLdvJ3NHpFvKLh/txNElpf/alEpLN54T/FeFuCUu6fniFTx2EZl/1GWADj56OpIWo6SqaxsjL7yUlAPmrYI7hFawHBrAWpksyH2N55DbUFkWXv6H+bHmk+UzwVlQ84X20Q+4nwYuczvd6TW4nlQtiLWQoastgz64C0gIxBqMZKeazhoCwJcS9w0dD7OVi6lWnrhrBkyef8Q8i7hp07qRTBkU6++STr5BUjHhC1CSh9n4tv4rr9Sdl4SW/JxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DldRQgaxTdzy/Yxl2RnTAr5zF/PPwWAI+L/7k1J51UkHiuFA/6BPDfVfrdbCb0HaJUXyk5jq04kDkVt/vorgwCNcGqiWHiv0FijI5URyeoN29IOAIHzSFSQDTKb16y8ztts4w4gLjKUNlPR/9MVGdi5HdzCksPqBvlzxKexjOOdIlGMgVNBhpEZCd1Bip8IozKlrDmz+QzoBAOnfXlxSey7GqIgrpIbBw73/0g1NooTa22AbX2CBw2qepRcjbA7jpp9Fd8/5bI7ziPu8LFKJadLIdQ5YHVmLoXyaC21+z16l6SNKl7PLds6w/iQu0NRoAwfp2+ZDWQbZPkL86QB90g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: consulting@xxxxxxxxxxx, Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Michal Orzel <michal.orzel@xxxxxxx>, Xenia Ragiadakou <Xenia.Ragiadakou@xxxxxxx>, Ayan Kumar Halder <ayan.kumar.halder@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 12 Jul 2023 10:52:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.07.2023 12:32, Simone Ballarin wrote:
> From: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
>
> The xen sources contains violations of MISRA C:2012 Rule 7.2 whose
> headline states:
> "A 'u' or 'U' suffix shall be applied to all integer constants
> that are represented in an unsigned type".
>
> Add the 'U' suffix to integers literals with unsigned type.
>
> For the sake of uniformity, the following changes are made:
> - add the 'U' suffix to macros near
> 'CPU_BASED_ACTIVATE_SECONDARY_CONTROLS' and
> 'SECONDARY_EXEC_NOTIFY_VM_EXITING' macros in 'vmcs.h'
> - add the 'U' suffix to macros near 'INTR_INFO_VALID_MASK'
> macro in 'vmx.h'
>
> Signed-off-by: Gianluca Luparini <gianluca.luparini@xxxxxxxxxxx>
> Signed-off-by: Simone Ballarin <simone.ballarin@xxxxxxxxxxx>
> Reviewed-by: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> ---
> Changes in v3:
> - change 'Signed-off-by' ordering
> - change commit message
> - remove unnecessary changes in 'vvmx.c'
> - add 'uint32_t' casts in 'vvmx.c'
> - add missing 'U' in 'vmcs.h' macros
> - change macro to '(1u << 31)' in 'vmx.h'
> - remove unnecessary changes to 'vmx.h'
With this many changes I don't think you can retain an R-b, unless
the person it came from really explicitly agreed with at least all
not purely cosmetic changes (which I don't think was the case here).
Irrespective:
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
