[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] build: correct gas --noexecstack check
- To: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 12 Jul 2023 16:23:22 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K7CXn2W39dnnk5PdOufiMOKJrY1668M2OesQaA2XClM=; b=b2ZLc9NeT7/CYP6CSNjts20wQdWG+ItES21NB5GukIqrHr+EBEbsQhgE9r81CEscEjrjX8rzurg5j6foxM4e41lT+cLJOLXdy9EH5pSXZb27kvX05ViIcPI3hp3R9X824mp1yfNtDYKoK27gBcfyIcIfqCaiJcU5XLuNdoShLaD/ANOKYuIi+U8Ko+lMzb8pTdP9D3/809/EUT13BsNJxc5FnONwM0atcaNdpKcMw6Z8kZWgDzO4hr3rHg3rOsx/VZgjIko9fd0LMpWRC2JnTfO1ykxSdWQDcJF/3SYaYd5mUUQ5YCUR2bFYIGIVLxZqdrnFgqIb++hoc2JNZTC7Mw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gEog0XhmmjXJwf1bmTbVETiyZPVUb4JvbySmxk0jxodeMnrhpqk3DyuPEVbaSr8NecrSxOoEMOJMrNJ976txdW6Fc/ldqmYN2V6/avfGBwtJC/3jOGb9M6lQetpeehF1U19/kh98xFPQ0AGsAKRSJxWa3iuaK45+52GY40OxkCLtnXdXrMCzSES+MAnFRsyopKWJv/1Fo7DA36YVHHzJZadiaYyXYFY1HIUtZobQjVSmbV7iGbyusIQUNR4DwaKf6x6J9RTcNsTFLKo2lJBUmsYymtCv1Y2Ylvhqc967ULydWy0eJ/yoVu8+DPIwLezPd4C2LPrY9K9PqGWFnEjxHA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>
- Delivery-date: Wed, 12 Jul 2023 14:23:48 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
The check was missing an escape for the inner $, thus breaking things
in the unlikely event that the underlying assembler doesn't support this
option.
Fixes: 62d22296a95d ("build: silence GNU ld warning about executable stacks")
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -397,7 +397,7 @@ endif
AFLAGS += -D__ASSEMBLY__
-$(call cc-option-add,AFLAGS,CC,-Wa$(comma)--noexecstack)
+$(call cc-option-add,AFLAGS,CC,-Wa$$(comma)--noexecstack)
LDFLAGS-$(call ld-option,--warn-rwx-segments) += --no-warn-rwx-segments
|
