[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/6] libxl: use the cpuid feature names from cpufeatureset.h
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Wed, 12 Jul 2023 18:23:18 +0100
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
- Delivery-date: Wed, 12 Jul 2023 17:23:42 +0000
- Ironport-data: A9a23:1T3tAqzwUg4nV+Fiwad6t+cixirEfRIJ4+MujC+fZmUNrF6WrkUAn zcWDTqEa/aLZ2L2edolPNjk8E0C757VytNlTlY5qSAxQypGp/SeCIXCJC8cHc8wwu7rFxs7s ppEOrEsCOhuExcwcz/0auCJQUFUjP3OHfykTrafYEidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw/zF8EoHUMja4mtC5QRhPKoT5zcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KVxxx 8EmBAs2V0uk3tuMyY+yU9lCv9t2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKZOUYn1lQ/UfrSmM+hgGX/dDtJ7kqYv6Mt70DYzRBr0airO93QEjCPbZwMwBrC+ TydpwwVBDkCE9ic9GuXykiWl8HXrSbLZaFRV6y3o6sCbFq7mTVIVUx+uUGAiem0jAuyVsxSL 2QQ+zEytu4i+UqzVN7/Uhak5nmesXY0RN54A+A8rgaXxcL84QmDAXMfZiVcc9Fgv8gzLRQjz lKTlsnlLSBuuraSD3ma89+pQSiaYHZPazVYPGldEFVDuoO4yG0usv7RZutcIpOLoubOIGrXm gmwpRU3noU9tNFegs1X4mv7byKQSonhF1Blt1yLATP5vmuVd6b+OdX2tAGzAeJoad/AEwLf5 CVsd922trhmMH2bqMCarAzh9pmN7u3NDjDTiEUH83IJp2X0oC7LkWy9DVhDyKZV3iUsI2WBj Lf741852XOqFCLCgVVLS4ywEd826qPrCM7oUPvZBvIXPMggLVffoXkwORTAt4wIrKTLufhvU ap3jO72VSpKYUiZ5GfeqxghPU8DmXllmDK7qWHTxBW7y7uODEN5up9cWGZimtsRtfveyC2Mq oY3Cid/40kHOAEISnWNoNF7wJFjBSRTOK0aXOQNLrTYfVc5RD5+YxITqJt4E7FYc21uvr+g1 hmAtoVwkTITWVWvxd22V01e
- Ironport-hdrordr: A9a23:MgFRF6MkOw/am8BcTwL255DYdb4zR+YMi2TDj3oBMyC9Afboyv xG/c5riSMc7Qx7ZJhOo6HnBEDtewK+yXcx2/hrAV7AZniqhILLFvAa0WKK+VSJcUGQmI886U 4jSdkHNDSaNykesS+O2njeLz9W+qjizEnHv5a9815dCSttbLxt6Bo8MAySFUp7SWB9dMIE/D f23Kd6jgvlXU5SQtWwB3EDUeSGj9rXlKj+aRpDKw875BKIhTaI7qe/NxSDxB8RXx5G3L9nqA H+4kPEz5Tml8v+5g7X1mfV4ZgTsNz9yuFbDMjJptkJJi7qggOIYp0kf7GZpjg6rMym9V5vut jRpBULOdh19hrqDy2IiCqo/zOl/Ccl6nfkx1Pdq2Dku9bFSDUzDNcErZ5FczPCgnBQ8u1U4e Zu5Sa0ppBXBRTPkGDW/N7TTSxnkUKyvD4LjfMTtXpCSoETAYUh7LD3vXklUKvoLhiKqrzPI9 MeSf00I8wmNW9yWkqp/VWHBubcGUjbUC32BHTq8fblrgS+1EoJs3fxQ6ck7y09HEZXcege2w 2DCNUwqJheCsIZKblwC446MLSKI32ITByJK26cJ1PqfZt3Sk7lutr77vEv6O62Zppg9upDpL 3RFF5X8XU1YE2GM7zx4LRbth/KW2mzRjLr14VX4IV4oKT1QP7xPTSEU01GqbrpnxwzOLysZx +IAuMeP9bzaW/1XYpZ1Qz3XJdfbXEYTc0Oo94+H1aDuNjCJIHmvvHSNK+7HsumLR80HmfkRn cTVjn6I8tNqkitR3/jmRDUH3fgYFb28558GLXTu+IT1I8OPItRtRV9syXz2uibbTlZ9qAmdk p3J73q1qu9uGmt5G7Nq35kPxJMZ3wll4kIk0k60TPiH3mEBIrr4e/vCly69EH3VCNCcw==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Jul 11, 2023 at 11:22:29AM +0200, Roger Pau Monne wrote:
> The current implementation in libxl_cpuid_parse_config() requires
> keeping a list of cpuid feature bits that should be mostly in sync
> with the contents of cpufeatureset.h.
>
> Avoid such duplication by using the automatically generated list of
> cpuid features in INIT_FEATURE_NAMES in order to map feature names to
> featureset bits, and then translate from featureset bits into cpuid
> leaf, subleaf, register tuple.
>
> Note that the full contents of the previous cpuid translation table
> can't be removed. That's because some feature names allowed by libxl
> are not described in the featuresets, or because naming has diverged
> and the previous nomenclature is preserved for compatibility reasons.
>
> Should result in no functional change observed by callers, albeit some
> new cpuid features will be available as a result of the change.
>
> While there constify cpuid_flags name field.
>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Reviewed-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
