[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 0/3] Fixing ACPI error reporting display
- To: Elliott Mitchell <ehem+xen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 13 Jul 2023 10:38:37 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eNuaswZ2BjWORMItjz7/biMTYirV+bHvKdZ1wkJ92zY=; b=J6PqiBc0h9aLTqoWV+Y2M/Al4c5hfFCuyMdaLoVLbi1tMqLQr3mS3AG+u+WIVZtVRef8YyRNc6dbsx+WgDJhmLyRsKiYG+yKU2q2dttVAfafd9/bQGu96g0ytP77SrlrqQCBqqsvISs4SUSTWWxR0fNEd/nSzwaWAqHRLsbbjIIGIkF/htHIZXUu6CiH9+13Es6tECdpr4XdQEKsyy8IitFAvzzJpek5imm5x76HdifZjsjZBivaEzaRKhPE9RL3E7XcxKkYoGvw9DMarpFdFPv6iGYTuMoe6b5xWhFthBo+wwafAggSFs6qvHiB45ofnfvgCDO+GF5SDR9L8KxQxA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cPSd28T5I4jQEPF70PG1O5xRo1M0dogj22OU5YfTMtOjSGhNuRW1ltXTPoXx6YTbogy04O43c2zvxEfM2mBzIyeDSu3xEVMzAcUnWwrhgwsiUfoTtJ6iN9UTVLWH24dXBny5WD7jpWmuidk2NJsp/hNnC4QxIxTmyEjyWuYRHnqE7TLu6WjFDw9OWPvt14oSBKksRHGrDbEC1vvjm0GFPD1id6Dwbf13E3Vh5ZrrfGchQBIaSz/jhRpgXP1RAeObliRG9Jasmwa/HhkEi+wIeAzJlnvK+wU6kfpxEdHZp8VUSZqjitOa6IM337FegHUCYLidxwCNMJLjC72OOon7lg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 13 Jul 2023 08:38:50 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 12.07.2023 21:59, Elliott Mitchell wrote:
> This series has been seen previously. The issue is pretty simple, if
> ACPI errors occur there is a high probability they will occur on multiple
> cores at once.
Nit: Both here and in the title s/ACPI/APIC/, to not misguide people about
the area the series touches (just in case a v4 might be needed).
Jan
> Since there is no locking for `printk()` there is a need
> to emit the entire error with a single `printk()`.
>
> I believe this is roughly where things left off. The loop adjustment had
> been requested to be broken into a separate step. I had also goofed when
> adjusting the handling and the string order had gotten reversed.
>
> I'm unsure how best to make the `printk()` more maintainable. Yet more
> "%s" and entries[#] will be needed if additional bits get defined. I'm
> inclined to keep the string broken apart to hint as to how it matches
> the entry list. I'm okay with everything being fully concatenated if
> that is felt best.
>
>
> Elliott Mitchell (3):
> x86/APIC: include full string with error_interrupt() error messages
> x86/APIC: modify error_interrupt() to output using single printk()
> x86/APIC: adjustments to error_interrupt() loop
>
> xen/arch/x86/apic.c | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
>
|
